Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270357: [lworld] some jtreg tests disabled on AArch64 #480

Closed
wants to merge 2 commits into from

Conversation

nick-arm
Copy link
Member

@nick-arm nick-arm commented Jul 14, 2021

Several tests under runtime/valhalla and compiler/valhalla have @requires os.simpleArch == "x64". They should be enabled on AArch64 too.

A couple of these tests, as well as three of the existing ones, fail on AArch64 with some variant of:

java.lang.RuntimeException: Graph for 'TestBasicFunctionality::test3' contains different number of match nodes (expected 1 but got 0):

The regex pattern these tests are looking for is specific to the x86 opto assembly output. They regex needs to be adjusted for the AArch64 format. I'll do that after #457 is merged which also touches the same files.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8270357: [lworld] some jtreg tests disabled on AArch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/480/head:pull/480
$ git checkout pull/480

Update a local copy of the PR:
$ git checkout pull/480
$ git pull https://git.openjdk.java.net/valhalla pull/480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 480

View PR using the GUI difftool:
$ git pr show -t 480

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/480.diff

Several tests under runtime/valhalla and compiler/valhalla have
@requires os.simpleArch == "x64". They should be enabled on AArch64 too.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 14, 2021

👋 Welcome back ngasson! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 14, 2021

@nick-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270357: [lworld] some jtreg tests disabled on AArch64

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 14, 2021

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@nick-arm this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout missing-tests
git fetch https://git.openjdk.java.net/valhalla lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

@openjdk openjdk bot added merge-conflict and removed ready labels Jul 19, 2021
@openjdk openjdk bot added ready and removed merge-conflict labels Jul 21, 2021
@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Jul 21, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2021

@nick-arm
Your change (at version aa8ff76) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jul 26, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

Going to push as commit 46b88b5.
Since your change was applied there have been 8 commits pushed to the lworld branch:

  • ad0491e: 8271017: [lworld] Implement withfield changes from JDK-8269408 on AArch64
  • 8c11290: 8271154: [lworld] CDS LoaderConstraintsTest fails after injection of IdentityObject
  • a4066d7: 8244231: [lworld] Add support for ref-default and val-default inline classes.
  • 02584ab: 8269756: [lworld] Add tests for invalid withfield operands
  • 01cab82: 8271141: [lworld] Remove unused jvaluetype q member in jvalue
  • 64ad8d0: 8271113: [lworld] java/lang/constant/MethodHandleDescTest.java fails after JDK-8247376
  • 6bc5ea9: 8247376: [lworld] Constant API support for primitive classes
  • 4d42fe1: 8271025: [lworld] vmTestbase/jit/t/* tests fail after JDK-8237073

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 26, 2021

@TobiHartmann @nick-arm Pushed as commit 46b88b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants