Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8270350: [lworld] GeneratedMethodAccessor contains incorrect cast #483

Closed
wants to merge 1 commit into from

Conversation

@mlchung
Copy link
Member

@mlchung mlchung commented Jul 16, 2021

This patch updates the bytecode generated for core reflection to use ReferenceType descriptor in CONSTANT_Class_info for primitive classes. In addition, the VM classFileParser temporarily disables the class file version check for jdk/internal/reflect classes since it's still version 49 until JDK-8266010 is fixed.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8270350: [lworld] GeneratedMethodAccessor contains incorrect cast

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/483/head:pull/483
$ git checkout pull/483

Update a local copy of the PR:
$ git checkout pull/483
$ git pull https://git.openjdk.java.net/valhalla pull/483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 483

View PR using the GUI difftool:
$ git pr show -t 483

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/483.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 16, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 16, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270350: [lworld] GeneratedMethodAccessor contains incorrect cast

Reviewed-by: hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • aa84c4e: 8263024: Convert Valhalla tests using the old framework to the new framework

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 16, 2021

Webrevs

Copy link
Member

@hseigel hseigel left a comment

The classFileParser.cpp changes look good.
Thanks, Harold

@mlchung
Copy link
Member Author

@mlchung mlchung commented Jul 16, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 16, 2021

Going to push as commit 6d0ecdf.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • aa84c4e: 8263024: Convert Valhalla tests using the old framework to the new framework

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 16, 2021

@mlchung Pushed as commit 6d0ecdf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the JDK-8270350 branch Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants