Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268945: [lworld] Re-implement JDK-8267151 after merge #485

Closed
wants to merge 2 commits into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jul 19, 2021

The fix for JDK-8267151 has been omitted by the recent merge due to conflicts. This patch re-implements it.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8268945: [lworld] Re-implement JDK-8267151 after merge

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/485/head:pull/485
$ git checkout pull/485

Update a local copy of the PR:
$ git checkout pull/485
$ git pull https://git.openjdk.java.net/valhalla pull/485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 485

View PR using the GUI difftool:
$ git pr show -t 485

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/485.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 19, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268945: [lworld] Re-implement JDK-8267151 after merge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 9b5ae0a: 8270896: [lworld] C2 compilation fails with "Meet Not Symmetric"

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 19, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Jul 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

Going to push as commit b6e7836.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 9b5ae0a: 8270896: [lworld] C2 compilation fails with "Meet Not Symmetric"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@TobiHartmann Pushed as commit b6e7836.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant