Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244563: [lworld] Javac does not allow jlO to be express superclass of inline types. #49

Closed
wants to merge 1 commit into from

Conversation

sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented May 15, 2020

Tolerate jlO as an express supertype of an inline class.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8244563: [lworld] Javac does not allow jlO to be express superclass of inline types.

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/49/head:pull/49
$ git checkout pull/49

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 15, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 15, 2020

@sadayapalam This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244563: [lworld] Javac does not allow jlO to be express superclass of inline types.
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the lworld branch:

  • c82e6b9: 8244563: [lworld] Javac does not allow jlO to be express superclass of inline types.

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate c82e6b9815e50ece6f474b86390f85d1e0f9ced8.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented May 15, 2020

/integrate

1 similar comment
@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented May 15, 2020

/integrate

@openjdk openjdk bot closed this May 15, 2020
@openjdk openjdk bot added the integrated label May 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 15, 2020

@sadayapalam
Pushed as commit c82e6b9.

@sadayapalam sadayapalam deleted the JDK-8244563 branch May 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 15, 2020

@sadayapalam Warning! Your commit did not result in any changes! No push attempt will be made.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 15, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant