Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269756: [lworld] Add tests for invalid withfield operands #490

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jul 21, 2021

Please review this change to add a test for various scenarios involving withfield. The test was run locally on Linux x64 and using Mach5 tiers 1-2.

Note that the test temporarily is run with -Xint because it fails when run with -Xcomp. -Xint will be removed once it passes with -Xcomp.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8269756: [lworld] Add tests for invalid withfield operands

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/490/head:pull/490
$ git checkout pull/490

Update a local copy of the PR:
$ git checkout pull/490
$ git pull https://git.openjdk.java.net/valhalla pull/490/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 490

View PR using the GUI difftool:
$ git pr show -t 490

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/490.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 21, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269756: [lworld] Add tests for invalid withfield operands

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the lworld branch:

  • 01cab82: 8271141: [lworld] Remove unused jvaluetype q member in jvalue
  • 64ad8d0: 8271113: [lworld] java/lang/constant/MethodHandleDescTest.java fails after JDK-8247376
  • 6bc5ea9: 8247376: [lworld] Constant API support for primitive classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jul 21, 2021

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Tests look good to me.
Thank you for implementing them.

Fred

@hseigel
Copy link
Member Author

hseigel commented Jul 22, 2021

Thanks Fred for reviewing this!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

Going to push as commit 02584ab.
Since your change was applied there have been 3 commits pushed to the lworld branch:

  • 01cab82: 8271141: [lworld] Remove unused jvaluetype q member in jvalue
  • 64ad8d0: 8271113: [lworld] java/lang/constant/MethodHandleDescTest.java fails after JDK-8247376
  • 6bc5ea9: 8247376: [lworld] Constant API support for primitive classes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@hseigel Pushed as commit 02584ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants