Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8271113: [lworld] java/lang/constant/MethodHandleDescTest.java fails after JDK-8247376 #491

Closed
wants to merge 1 commit into from

Conversation

@mlchung
Copy link
Member

@mlchung mlchung commented Jul 22, 2021

It's a bug in the fix of JDK-8247376 that appends ".ref" in the display name if the descriptor is not Q-descriptor. It can't determine if the class represented by the given L-descriptor string is a primitive class or not. This patch will revert the change in ClassClass::displayName. We will follow up if ClassDesc::displayName should return a different string for primitive reference type vs primitive value type in a separate issue.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8271113: [lworld] java/lang/constant/MethodHandleDescTest.java fails after JDK-8247376

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/491/head:pull/491
$ git checkout pull/491

Update a local copy of the PR:
$ git checkout pull/491
$ git pull https://git.openjdk.java.net/valhalla pull/491/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 491

View PR using the GUI difftool:
$ git pr show -t 491

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/491.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 22, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271113: [lworld] java/lang/constant/MethodHandleDescTest.java fails after JDK-8247376

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 22, 2021

Webrevs

@mlchung
Copy link
Member Author

@mlchung mlchung commented Jul 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

Going to push as commit 64ad8d0.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@mlchung Pushed as commit 64ad8d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the JDK-8271113 branch Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant