Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271017: [lworld] Implement withfield changes from JDK-8269408 on AArch64 #492

Closed
wants to merge 1 commit into from

Conversation

nick-arm
Copy link
Member

@nick-arm nick-arm commented Jul 22, 2021

This just applies the changes in JDK-8269408 to the AArch64 port.

The old InterpreterRuntime::withfield() is removed as it has no more users, and I've renamed withfield2 to withfield (presumably this was the original intention?).


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8271017: [lworld] Implement withfield changes from JDK-8269408 on AArch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/492/head:pull/492
$ git checkout pull/492

Update a local copy of the PR:
$ git checkout pull/492
$ git pull https://git.openjdk.java.net/valhalla pull/492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 492

View PR using the GUI difftool:
$ git pr show -t 492

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/492.diff

…ch64

This just applies the changes in JDK-8269408 to the AArch64 port.

The old InterpreterRuntime::withfield() is removed as it has no more
users, and I've renamed withfield2 to withfield.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 22, 2021

👋 Welcome back ngasson! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@nick-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271017: [lworld] Implement withfield changes from JDK-8269408 on AArch64

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the lworld branch:

  • a4066d7: 8244231: [lworld] Add support for ref-default and val-default inline classes.
  • 02584ab: 8269756: [lworld] Add tests for invalid withfield operands
  • 01cab82: 8271141: [lworld] Remove unused jvaluetype q member in jvalue

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 22, 2021

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Changes look good to me.
Thank you for the cleanup in interpreterRuntime.cpp.

Fred

@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Jul 23, 2021

Thanks @fparain!

@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Jul 23, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@nick-arm
Your change (at version bca4758) is now ready to be sponsored by a Committer.

@fparain
Copy link
Collaborator

@fparain fparain commented Jul 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

Going to push as commit ad0491e.
Since your change was applied there have been 4 commits pushed to the lworld branch:

  • 8c11290: 8271154: [lworld] CDS LoaderConstraintsTest fails after injection of IdentityObject
  • a4066d7: 8244231: [lworld] Add support for ref-default and val-default inline classes.
  • 02584ab: 8269756: [lworld] Add tests for invalid withfield operands
  • 01cab82: 8271141: [lworld] Remove unused jvaluetype q member in jvalue

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2021

@fparain @nick-arm Pushed as commit ad0491e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants