Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271229: [lworld] Test serviceability/sa/ClhsdbDumpclass.java fails with unexpected end of file #498

Closed
wants to merge 1 commit into from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented Jul 27, 2021

Please review those changes fixing the HotSpot agent to correctly dump classes even in presence of injected interfaces.
Fix failures of serviceability/sa/ClhsdbDumpclass.java on all platforms (tested with Mach5, tiers 1 to 3).

Thank you,

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8271229: [lworld] Test serviceability/sa/ClhsdbDumpclass.java fails with unexpected end of file

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/498/head:pull/498
$ git checkout pull/498

Update a local copy of the PR:
$ git checkout pull/498
$ git pull https://git.openjdk.java.net/valhalla pull/498/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 498

View PR using the GUI difftool:
$ git pr show -t 498

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/498.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 27, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271229: [lworld] Test serviceability/sa/ClhsdbDumpclass.java fails with unexpected end of file

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the lworld branch:

  • 865c6b5: [lworld] Problemlist TestNativeClone until 8270098 is fixed
  • 6160238: 8270995: [lworld] G1BarrierSetC2::step_over_gc_barrier asserts with "bad barrier shape"
  • ae5fc42: 8271282: [lworld] C2 compilation fails with "bad AD file"

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jul 27, 2021

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Looks good

@fparain
Copy link
Collaborator Author

fparain commented Jul 27, 2021

Thanks for the review!

Fred

@fparain
Copy link
Collaborator Author

fparain commented Jul 27, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 27, 2021

Going to push as commit 702f1ba.
Since your change was applied there have been 3 commits pushed to the lworld branch:

  • 865c6b5: [lworld] Problemlist TestNativeClone until 8270098 is fixed
  • 6160238: 8270995: [lworld] G1BarrierSetC2::step_over_gc_barrier asserts with "bad barrier shape"
  • ae5fc42: 8271282: [lworld] C2 compilation fails with "bad AD file"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 27, 2021
@openjdk
Copy link

openjdk bot commented Jul 27, 2021

@fparain Pushed as commit 702f1ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fparain fparain deleted the class_writer branch Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants