8271309: [lworld] FieldModification event: new_value is invalid for Q objects

[alexmenkov]

The fix adds handling of Q-type fields the same way as L-type

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8271309: [lworld] FieldModification event: new_value is invalid for Q objects

Reviewers

• Frederic Parain (@fparain - Committer) ⚠️ Review applies to 4f1bedb

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/499/head:pull/499
$ git checkout pull/499

Update a local copy of the PR:
$ git checkout pull/499
$ git pull https://git.openjdk.java.net/valhalla pull/499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 499

View PR using the GUI difftool:
$ git pr show -t 499

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/499.diff

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271309: [lworld] FieldModification event: new_value is invalid for Q objects

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the lworld branch:

• aace1e5: 8271397: [lworld] SIGSEGV in ciKlass::is_subtype_of
• bebb40f: 8271380: [lworld] Intrinsify j.l.Class::asPrimaryType/asValueType
• 2276111: 8271389: [lworld] Improve typing of primitiveObject.getClass()
• 7ac7662: 8271324: [lworld] java/foreign/* tests fail with "guarantee(sect->end() <= tend) failed: sanity"
• 92f9ea9: 8271330: [lworld] SIGSEGV in MemNode::find_previous_store
• 8c1359a: 8269956: [lworld] javac should generate ldc LPoint; for class literal Point.class
• 702f1ba: 8271229: [lworld] Test serviceability/sa/ClhsdbDumpclass.java fails with unexpected end of file
• 865c6b5: [lworld] Problemlist TestNativeClone until 8270098 is fixed
• 6160238: 8270995: [lworld] G1BarrierSetC2::step_over_gc_barrier asserts with "bad barrier shape"
• ae5fc42: 8271282: [lworld] C2 compilation fails with "bad AD file"
• ... and 21 more: https://git.openjdk.java.net/valhalla/compare/37ea410358921ff5f0cc124a0c1b3a09e34d67e4...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (25daf4c6)
• 00: Full (4f1bedb9)

[fparain]

Hi Alex,

Thank you for fixing this. Overall, looks good to me.

Many of the tests related to the FieldModification event are still not working (they are commented with a KNOWN ISSUE comment) because the withfield bytecode still doesn't support JVMTI FieldModification event. Do you have a CR to track this issue?

Regards,

Fred

[fparain]

It would be cleaner to have modified be declared as a bool, or to re-write the test to modified == 1.

[alexmenkov]

Many of the tests related to the FieldModification event are still not working (they are commented with a KNOWN ISSUE comment) because the withfield bytecode still doesn't support JVMTI FieldModification event. Do you have a CR to track this issue?

Filed JDK-8271355

[alexmenkov]

It would be cleaner to have modified be declared as a bool, or to re-write the test to modified == 1.

C-style detected :)
Will fix it.

[fparain]

Thank you for the changes.

[alexmenkov]

/integrate

[openjdk]

@alexmenkov
Your change (at version 25daf4c) is now ready to be sponsored by a Committer.

[alexmenkov]

@fparain could you please sponsor the fix

[MrSimms]

/sponsor

[openjdk]

Going to push as commit 1282380.
Since your change was applied there have been 31 commits pushed to the lworld branch:

• aace1e5: 8271397: [lworld] SIGSEGV in ciKlass::is_subtype_of
• bebb40f: 8271380: [lworld] Intrinsify j.l.Class::asPrimaryType/asValueType
• 2276111: 8271389: [lworld] Improve typing of primitiveObject.getClass()
• 7ac7662: 8271324: [lworld] java/foreign/* tests fail with "guarantee(sect->end() <= tend) failed: sanity"
• 92f9ea9: 8271330: [lworld] SIGSEGV in MemNode::find_previous_store
• 8c1359a: 8269956: [lworld] javac should generate ldc LPoint; for class literal Point.class
• 702f1ba: 8271229: [lworld] Test serviceability/sa/ClhsdbDumpclass.java fails with unexpected end of file
• 865c6b5: [lworld] Problemlist TestNativeClone until 8270098 is fixed
• 6160238: 8270995: [lworld] G1BarrierSetC2::step_over_gc_barrier asserts with "bad barrier shape"
• ae5fc42: 8271282: [lworld] C2 compilation fails with "bad AD file"
• ... and 21 more: https://git.openjdk.java.net/valhalla/compare/37ea410358921ff5f0cc124a0c1b3a09e34d67e4...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@MrSimms @alexmenkov Pushed as commit 1282380.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.