Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271380: [lworld] Intrinsify j.l.Class::asPrimaryType/asValueType #504

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jul 28, 2021

TestIntrinsics.java fails after JDK-8269956 which replace some usages of MyValue.class by MyValue.class.asValueType(). The problem is that asValueType() is not always inlined by C2 and therefore IR verification fails.

This patch intrinsifies the methods similar to what we did in old L/Q world (e895128f). I've also modified the test to consistently use asPrimaryType/asValueType.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8271380: [lworld] Intrinsify j.l.Class::asPrimaryType/asValueType

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/504/head:pull/504
$ git checkout pull/504

Update a local copy of the PR:
$ git checkout pull/504
$ git pull https://git.openjdk.java.net/valhalla pull/504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 504

View PR using the GUI difftool:
$ git pr show -t 504

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/504.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271380: [lworld] Intrinsify j.l.Class::asPrimaryType/asValueType

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 7ac7662: 8271324: [lworld] java/foreign/* tests fail with "guarantee(sect->end() <= tend) failed: sanity"

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jul 28, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Jul 28, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

Going to push as commit bebb40f.
Since your change was applied there have been 2 commits pushed to the lworld branch:

  • 2276111: 8271389: [lworld] Improve typing of primitiveObject.getClass()
  • 7ac7662: 8271324: [lworld] java/foreign/* tests fail with "guarantee(sect->end() <= tend) failed: sanity"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@TobiHartmann Pushed as commit bebb40f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant