8245216: [lworld] The JVM should inject the IdentityObject interface to types which need it

[fparain]

Please review these changes for JDK-8245216.

This code makes the JVM to inject the IdentityObject interface when needed.
The details are in the CR:
https://bugs.openjdk.java.net/browse/JDK-8245216

Thank you,

Fred

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8245216: [lworld] The JVM should inject the IdentityObject interface to types which need it ⚠️ Title mismatch between PR and JBS.

Reviewers

• Harold Seigel (hseigel - Committer) ⚠️ Review applies to 00cfcb6

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/51/head:pull/51
$ git checkout pull/51

[bridgekeeper]

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

[openjdk]

@fparain This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245216: lworld] The JVM should inject the IdentityObject interface to types which need it

Reviewed-by: hseigel

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the lworld branch:

• e8894bd: 8245019: lworld] SIGSEGV in BufferBlob::buffered value type due to instruction memory corruption

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate e8894bd7d8690f8232664ac6eebe2b2045430571.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 04: Full - Incremental (ca70fca)
• 03: Full - Incremental (53a29d1)
• 02: Full - Incremental (00cfcb6)
• 01: Full - Incremental (521561c)
• 00: Full (1f8d4bb)

[fparain]

Got some crashes during testing, investigating...
[update] Class instrumentation/redefinition requires some fixes.

[sadayapalam]

This patch addresses the two langtools failure it should. Thanks!

However, hotspot/jtreg/runtime/valhalla/valuetypes/testSupers/TestSuperClasses.java is still referencing withdrawn classes and fails. Are you able to include a fix for that too ?

I looked into preparing a patch, but not familiar with jcod files...

[fparain]

The PR has been updated with the following changes:

• fix JVMTI class file reconstruction to exclude injected interfaces
• fix java.lang.Class.ArrayMethods and TestSuperClasses tests
• fix JVMCI implementation and test

No more regression with tier1. Testing with tier2 and tier3 is in progress.

[fparain]

Stress testing shown an issue with metaspace allocation/deallocation.
Withdrawing the PR until the issue has been solved.

[hseigel]

Can you update the comment at line 63 to include java.lang.IdentityObject?

[hseigel]

Changes look good, other than the nit about the comment in verificationType.cpp.
Thanks for doing this.

[fparain]

Thank you Harold. I've updated the comment in verificationType.cpp in the last commit.

Fred

[fparain]

/integrate

[openjdk]

@fparain The following commits have been pushed to lworld since your change was applied:

• e8894bd: 8245019: lworld] SIGSEGV in BufferBlob::buffered value type due to instruction memory corruption

Your commit was automatically rebased without conflicts.

Pushed as commit ec75333.