Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271544: [lworld] GraphBuilder::withfield should handle identity class holder #512

Closed
wants to merge 2 commits into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jul 30, 2021

The test added by 8269756 asserts in GraphBuilder::withfield because the holder klass is not an inline klass. C1 should handle that edge case by deoptimizing.

Best regards,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8271544: [lworld] GraphBuilder::withfield should handle identity class holder

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/512/head:pull/512
$ git checkout pull/512

Update a local copy of the PR:
$ git checkout pull/512
$ git pull https://git.openjdk.java.net/valhalla pull/512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 512

View PR using the GUI difftool:
$ git pr show -t 512

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/512.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 30, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271544: [lworld] GraphBuilder::withfield should handle identity class holder

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • c8b88f2: 8271535: [lworld] TestLWorld fails during IR verification because method is not inlined

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Jul 30, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

Going to push as commit bdf2799.
Since your change was applied there have been 108 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@TobiHartmann Pushed as commit bdf2799.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant