Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271508: [lworld] disallow primitive classes with super_class of 0 #513

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jul 30, 2021

Please review this small fix for valhalla bug JDK-8271508. The fix was tested with a new regression test, with JCK lang and VM, mach5 tiers 1-2 on Linux, Mac OS, and WIndows, and mach5 tiers 3-5 on Linux x64.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8271508: [lworld] disallow primitive classes with super_class of 0

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/513/head:pull/513
$ git checkout pull/513

Update a local copy of the PR:
$ git checkout pull/513
$ git pull https://git.openjdk.java.net/valhalla pull/513/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 513

View PR using the GUI difftool:
$ git pr show -t 513

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/513.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 30, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271508: [lworld] disallow primitive classes with super_class of 0

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 565 new commits pushed to the lworld branch:

  • bdf2799: 8271544: [lworld] GraphBuilder::withfield should handle identity class holder
  • 2ca8eba: Merge jdk
  • a066c7b: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • 072fe48: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ecd4455: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • 9bc52af: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 752b6df: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • ... and 555 more: https://git.openjdk.java.net/valhalla/compare/233d7bbb84a874d96e35657ff533d9c5903fbea6...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2021

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Looks good

@hseigel
Copy link
Member Author

@hseigel hseigel commented Jul 30, 2021

Thanks David for reviewing this!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

Going to push as commit 44784e4.
Since your change was applied there have been 565 commits pushed to the lworld branch:

  • bdf2799: 8271544: [lworld] GraphBuilder::withfield should handle identity class holder
  • 2ca8eba: Merge jdk
  • a066c7b: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • 072fe48: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ecd4455: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • 9bc52af: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 752b6df: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • ... and 555 more: https://git.openjdk.java.net/valhalla/compare/233d7bbb84a874d96e35657ff533d9c5903fbea6...lworld

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@hseigel Pushed as commit 44784e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants