New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271528: [lworld] [TESTBUG] Several C2 IR tests fail on AArch64 #515
Conversation
The regexes just need to be adjusted slightly for the different opto assembly output. Also removed an unnecessary extra black line after some loadConP instructions which caused match failures. Test hotspot_valhalla on x86 and AArch64.
|
@nick-arm This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.
|
@chhagedorn I tried to align this with the changes you made in openjdk/jdk@9856ace |
Webrevs
|
The adaptations look good! @TobiHartmann additionally submitted some testing.
I've just seen that TestUnloadedInlineTypeField is not enabled for aarch64. Was that one missed?
protected static final String CHECKCAST_ARRAY = "(cmp.*precise klass \\[(L|Q)compiler/valhalla/inlinetypes/MyValue.*" + END; | ||
protected static final String CHECKCAST_ARRAYCOPY = "(.*call_leaf_nofp,runtime checkcast_arraycopy.*" + END; | ||
protected static final String JLONG_ARRAYCOPY = "(.*call_leaf_nofp,runtime jlong_disjoint_arraycopy.*" + END; | ||
protected static final String CHECKCAST_ARRAY = "(((?i:cmp|CLFI|CLR).*" + MYVALUE_KLASS + ".*;:|.*(?i:mov|or).*" + MYVALUE_KLASS + ".*;:.*\\R.*(cmp|CMP|CLR))" + END; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLFI
and CLR
is only used for s390 and PPC, respectively. But I guess it does not hurt to keep it that way.
test/hotspot/jtreg/compiler/valhalla/inlinetypes/InlineTypes.java
Outdated
Show resolved
Hide resolved
Testing looks good. |
Thanks, I missed that one. I've enabled too now (passes on AArch64). |
/integrate |
/sponsor |
Going to push as commit e13315a.
Your commit was automatically rebased without conflicts. |
@TobiHartmann @nick-arm Pushed as commit e13315a. |
The regexes just need to be adjusted slightly for the different opto assembly output. Also removed an unnecessary extra black line after some loadConP instructions which caused match failures.
Test hotspot_valhalla on x86 and AArch64.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/515/head:pull/515
$ git checkout pull/515
Update a local copy of the PR:
$ git checkout pull/515
$ git pull https://git.openjdk.java.net/valhalla pull/515/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 515
View PR using the GUI difftool:
$ git pr show -t 515
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/515.diff