Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8271405: [lworld] Redo test/jdk/java/lang/invoke/VarHandles changes for JDK-8269956 #516

Closed
wants to merge 3 commits into from

Conversation

@mlchung
Copy link
Member

@mlchung mlchung commented Aug 2, 2021

test/jdk/java/lang/invoke/VarHandles are generated from the template files. Redo the fix for JDK-8269956 and update the template files.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8271405: [lworld] Redo test/jdk/java/lang/invoke/VarHandles changes for JDK-8269956

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/516/head:pull/516
$ git checkout pull/516

Update a local copy of the PR:
$ git checkout pull/516
$ git pull https://git.openjdk.java.net/valhalla pull/516/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 516

View PR using the GUI difftool:
$ git pr show -t 516

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/516.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 2, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271405: [lworld] Redo test/jdk/java/lang/invoke/VarHandles changes for JDK-8269956

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 569 new commits pushed to the lworld branch:

  • ecca7a0: 8271536: [lworld] VerifyError in hotspot/jtreg/runtime/classFileParserBug/NameAndTypeSig.java
  • 44784e4: 8271508: [lworld] disallow primitive classes with super_class of 0
  • bdf2799: 8271544: [lworld] GraphBuilder::withfield should handle identity class holder
  • 2ca8eba: Merge jdk
  • a066c7b: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • 072fe48: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ecd4455: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • ... and 559 more: https://git.openjdk.java.net/valhalla/compare/aace1e5c4b4c425b66092c0c67b1000bc1a663e7...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 2, 2021

Webrevs

@mlchung
Copy link
Member Author

@mlchung mlchung commented Aug 3, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

Going to push as commit 9fe2304.
Since your change was applied there have been 569 commits pushed to the lworld branch:

  • ecca7a0: 8271536: [lworld] VerifyError in hotspot/jtreg/runtime/classFileParserBug/NameAndTypeSig.java
  • 44784e4: 8271508: [lworld] disallow primitive classes with super_class of 0
  • bdf2799: 8271544: [lworld] GraphBuilder::withfield should handle identity class holder
  • 2ca8eba: Merge jdk
  • a066c7b: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • 072fe48: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ecd4455: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • d994b93: 8266054: VectorAPI rotate operation optimization
  • ed1cb24: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • ... and 559 more: https://git.openjdk.java.net/valhalla/compare/aace1e5c4b4c425b66092c0c67b1000bc1a663e7...lworld

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@mlchung Pushed as commit 9fe2304.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the test-fix branch Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant