Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245019: [lworld] SIGSEGV in BufferBlob::buffered value type due to instruction memory corruption #52

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented May 20, 2020

The layout of BufferedValueTypeBlob is incorrectly computed (sizeof(BufferBlob) instead of sizeof(BufferedValueTypeBlob)) and as a result, the instructions at the start of the blob are overwritten by the C++ object header. This only happens with a product build, I assume with a debug build there is some additional padding.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8245019: [lworld] SIGSEGV in BufferBlob::buffered value type due to instruction memory corruption ⚠️ Title mismatch between PR and JBS.

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/52/head:pull/52
$ git checkout pull/52

@TobiHartmann TobiHartmann changed the title 8245019:[lworld] SIGSEGV in BufferBlob::buffered value type due to instruction memory corruption 8245019: [lworld] SIGSEGV in BufferBlob::buffered_value_type due to instruction memory corruption May 20, 2020
@TobiHartmann TobiHartmann changed the title 8245019: [lworld] SIGSEGV in BufferBlob::buffered_value_type due to instruction memory corruption 8245019: [lworld] SIGSEGV in BufferBlob::buffered value type due to instruction memory corruption May 20, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 20, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245019: lworld] SIGSEGV in BufferBlob::buffered value type due to instruction memory corruption
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 9a5e8f3921ae281fd64fddefdd3417ab3b90406f.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented May 20, 2020

/integrate

@openjdk openjdk bot closed this May 20, 2020
@openjdk openjdk bot added the integrated label May 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2020

@TobiHartmann
Pushed as commit e8894bd.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 20, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant