New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272290: [lworld] Disable CDS if InlineTypePassFieldsAsArgs has changed #526
8272290: [lworld] Disable CDS if InlineTypePassFieldsAsArgs has changed #526
Conversation
|
@iklam This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Webrevs
|
@ioilam Thanks for fixing this. To give more context, this issue was uncovered when the CDS archive includes primitive classes such as This looks fine to me. It'd be good to have someone from the runtime to review it. |
If any of the following VM options have different values between CDS dump time and runtime, we cannot load the CDS archive:
FlatArrayElementMaxOops
FlatArrayElementMaxSize
InlineFieldMaxFlatSize
InlineTypePassFieldsAsArgs
InlineTypeReturnedAsFields
Testing with mach5 tiers 1-2
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/526/head:pull/526
$ git checkout pull/526
Update a local copy of the PR:
$ git checkout pull/526
$ git pull https://git.openjdk.java.net/valhalla pull/526/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 526
View PR using the GUI difftool:
$ git pr show -t 526
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/526.diff