Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8272397: [lworld] Move ValueBootstrapMethods to java.lang.runtime #529

Closed
wants to merge 1 commit into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Aug 12, 2021

ValueBootstrapMethods is the default implementation of Object::equals and Object::hashCode
for primitive class. It does not belong to java.lang.invoke. java.lang.runtime is a more
appropriate home. It can also share the code in ObjectMethods.

The methods are now renamed to java.lang.runtime.PrimitiveObjectMethods::isSubtitutable
and primitiveObjectHashCode.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8272397: [lworld] Move ValueBootstrapMethods to java.lang.runtime

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/529/head:pull/529
$ git checkout pull/529

Update a local copy of the PR:
$ git checkout pull/529
$ git pull https://git.openjdk.java.net/valhalla pull/529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 529

View PR using the GUI difftool:
$ git pr show -t 529

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/529.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 12, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272397: [lworld] Move ValueBootstrapMethods to java.lang.runtime

Reviewed-by: fparain, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the lworld branch:

  • 96f2052: 8272511: [lworld] Disable PhaseIdealLoop::try_sink_out_of_loop until optimization is stable in mainline
  • a5516c1: 8272290: [lworld] Disable CDS if InlineTypePassFieldsAsArgs has changed
  • f85b10b: 8272307: [lworld] [AArch64] TestCallingConventionC1 test63 and test64 get incorrect result
  • a8994ba: 8272041: [lworld] CDS heap dump fails with primitive objects
  • 14723f9: 8271924: [lworld] Crashes in ZBarrierSetRuntime::load_barrier_on_oop_array
  • bdaa4af: Merge jdk
  • 0a27f26: 8265057: G1: Investigate removal of maintenance of two BOT thresholds
  • eec64f5: 8256844: Make NMT late-initializable
  • 4df1bc4: 6350025: API documentation for JOptionPane using deprecated methods.
  • efcdcc7: 8270893: IndexOutOfBoundsException while reading large TIFF file
  • ... and 75 more: https://git.openjdk.java.net/valhalla/compare/dcfafdb4c88fdc8e55679a9ea86459be182c31e1...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlchung mlchung changed the title JDK-8272397: [world] Move ValueBootstrapMethods to java.lang.runtime JDK-8272397: [lworld] Move ValueBootstrapMethods to java.lang.runtime Aug 12, 2021
@openjdk openjdk bot removed the ready label Aug 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 12, 2021

Webrevs

@openjdk openjdk bot added the ready label Aug 12, 2021
Copy link
Collaborator

@fparain fparain left a comment

HotSpot changes look good.

Fred

Copy link
Collaborator

@RogerRiggs RogerRiggs left a comment

LGTM

@mlchung
Copy link
Member Author

@mlchung mlchung commented Aug 17, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

Going to push as commit 9c2af85.
Since your change was applied there have been 87 commits pushed to the lworld branch:

  • ad20c66: 8271556: [lworld] java.lang.BootstrapMethodError in .equals() for primitive record
  • 9d05484: 8272400: [lworld] serviceability/sa/CDSJMapClstats.java fails: No suitable match for type of address
  • 96f2052: 8272511: [lworld] Disable PhaseIdealLoop::try_sink_out_of_loop until optimization is stable in mainline
  • a5516c1: 8272290: [lworld] Disable CDS if InlineTypePassFieldsAsArgs has changed
  • f85b10b: 8272307: [lworld] [AArch64] TestCallingConventionC1 test63 and test64 get incorrect result
  • a8994ba: 8272041: [lworld] CDS heap dump fails with primitive objects
  • 14723f9: 8271924: [lworld] Crashes in ZBarrierSetRuntime::load_barrier_on_oop_array
  • bdaa4af: Merge jdk
  • 0a27f26: 8265057: G1: Investigate removal of maintenance of two BOT thresholds
  • eec64f5: 8256844: Make NMT late-initializable
  • ... and 77 more: https://git.openjdk.java.net/valhalla/compare/dcfafdb4c88fdc8e55679a9ea86459be182c31e1...lworld

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 17, 2021
@openjdk openjdk bot added integrated and removed ready labels Aug 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@mlchung Pushed as commit 9c2af85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants