Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272400: [lworld] serviceability/sa/CDSJMapClstats.java fails: No suitable match for type of address #532

Conversation

iklam
Copy link
Member

@iklam iklam commented Aug 17, 2021

This is a fix in CDS and SA to get CDSJMapClstats.java (and a bunch of other SA tests) to pass:

  • Implement skeletal FlatArrayKlass and InlineKlass types in SA
  • Implement the CDS C++ vtable lookup of these two types.

After this fix, only 2 out of 191 tests in test/hotspot/jtreg/serviceability/ are still failing.

However, support of these two types are incomplete in SA, so programs that try to use the SA APIs to access VM internals will not work. The full SA support of inlined types will be done separately in https://bugs.openjdk.java.net/browse/JDK-8205036


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8272400: [lworld] serviceability/sa/CDSJMapClstats.java fails: No suitable match for type of address

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/532/head:pull/532
$ git checkout pull/532

Update a local copy of the PR:
$ git checkout pull/532
$ git pull https://git.openjdk.java.net/valhalla pull/532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 532

View PR using the GUI difftool:
$ git pr show -t 532

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/532.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2021

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 17, 2021

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272400: [lworld] serviceability/sa/CDSJMapClstats.java fails: No suitable match for type of address

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 96f2052: 8272511: [lworld] Disable PhaseIdealLoop::try_sink_out_of_loop until optimization is stable in mainline

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Aug 17, 2021

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Looks like a good start to fix the SA.
Thank you for doing it.

Fred

@iklam
Copy link
Member Author

iklam commented Aug 17, 2021

Thanks @fparain for the review. Mach5 tier1-2 clean.
/integrate

@openjdk
Copy link

openjdk bot commented Aug 17, 2021

Going to push as commit 9d05484.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 96f2052: 8272511: [lworld] Disable PhaseIdealLoop::try_sink_out_of_loop until optimization is stable in mainline

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 17, 2021
@openjdk
Copy link

openjdk bot commented Aug 17, 2021

@iklam Pushed as commit 9d05484.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants