Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271583: [lworld] primitive records can't be reference favoring #533

Closed

Conversation

@jespersm
Copy link
Contributor

@jespersm jespersm commented Aug 17, 2021

This patch lets the compiler pick up a record which can be primitive records and reference favoring, such as

primitive record Point.val(int x, int y) {}

The lowering had to be adjusted so that the correct receiver type is generated.

See https://bugs.openjdk.java.net/browse/JDK-8271583


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8271583: [lworld] primitive records can't be reference favoring

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/533/head:pull/533
$ git checkout pull/533

Update a local copy of the PR:
$ git checkout pull/533
$ git pull https://git.openjdk.java.net/valhalla pull/533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 533

View PR using the GUI difftool:
$ git pr show -t 533

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/533.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 17, 2021

👋 Welcome back jespersm! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@jespersm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271583: [lworld] primitive records can't be reference favoring

Reviewed-by: sadayapalam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 156 new commits pushed to the lworld branch:

  • dd0a9eb: 8272306: [lworld] Fix incorrectly merged code in classListParser.cpp
  • 7553793: 8272793: [lworld] Test CustomClassListDump.java fails with Pattern "CustomLoadee id: [0-9]+ super: [0-9]+ source: .*/custom.jar" not found in classlist
  • aaa7401: 8272753: [lworld] "Invalid frame size" assert in frame::repair_sender_sp
  • 55f8d9e: Merge jdk
  • 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
  • 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 30b0f82: 8272626: Avoid C-style array declarations in java.*
  • e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
  • 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
  • 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • ... and 146 more: https://git.openjdk.java.net/valhalla/compare/9c2af854deb759d4b7879191d7ff5807bf679e32...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sadayapalam) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 17, 2021

Webrevs

Copy link
Collaborator

@sadayapalam sadayapalam left a comment

Other than the test changes requested, this looks good.

* @summary [lworld] primitive records can't be reference favoring
* @compile -XDallowWithFieldOperator RefFlavoredRecord.java
* @run main/othervm RefFlavoredRecord
*/
Copy link
Collaborator

@sadayapalam sadayapalam Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test should not require XDallowWithFieldOperator and also likely "othervm" in the run tag.

And you should also be able to condense the @compile and @run into just @run ??

@jespersm
Copy link
Contributor Author

@jespersm jespersm commented Aug 23, 2021

I fixed the unneeded @compile line, but I'm not sure about changing the main/othervm. Most tests in Valhalla use 'main/othervm', but perhaps that's just coincidence, or a misunderstanding that's been copy/paste's around?

@jespersm
Copy link
Contributor Author

@jespersm jespersm commented Aug 23, 2021

/integrate

@openjdk openjdk bot added the sponsor label Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@jespersm
Your change (at version c0ce255) is now ready to be sponsored by a Committer.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@jespersm
Your change (at version c0ce255) is now ready to be sponsored by a Committer.

@sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Aug 24, 2021

I fixed the unneeded @compile line, but I'm not sure about changing the main/othervm. Most tests in Valhalla use 'main/othervm', but perhaps that's just coincidence, or a misunderstanding that's been copy/paste's around?

As per jtreg tag spec:

/othervm
Some test harnesses reuse a VM between tests. This option forces the action to be run in a fresh VM subprocess. Use this option if you need to specify VM options, or if the action might crash the VM.

This option should not be required for most of the valhalla tests - I will create a separate ticket for this clean up.

@sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Aug 24, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@sadayapalam Unknown command othervm - for a list of valid commands use /help.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

Going to push as commit a74a1ce.
Since your change was applied there have been 156 commits pushed to the lworld branch:

  • dd0a9eb: 8272306: [lworld] Fix incorrectly merged code in classListParser.cpp
  • 7553793: 8272793: [lworld] Test CustomClassListDump.java fails with Pattern "CustomLoadee id: [0-9]+ super: [0-9]+ source: .*/custom.jar" not found in classlist
  • aaa7401: 8272753: [lworld] "Invalid frame size" assert in frame::repair_sender_sp
  • 55f8d9e: Merge jdk
  • 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
  • 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 30b0f82: 8272626: Avoid C-style array declarations in java.*
  • e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
  • 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
  • 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • ... and 146 more: https://git.openjdk.java.net/valhalla/compare/9c2af854deb759d4b7879191d7ff5807bf679e32...lworld

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@sadayapalam @jespersm Pushed as commit a74a1ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants