Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272793: [lworld] Test CustomClassListDump.java fails with Pattern "CustomLoadee id: [0-9]+ super: [0-9]+ source: .*/custom.jar" not found in classlist #537

Closed
wants to merge 1 commit into from

Conversation

@fparain
Copy link
Collaborator

@fparain fparain commented Aug 20, 2021

Fixing test by taking into account the injected IdentityObject interface in patterns used to analyze the output.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8272793: [lworld] Test CustomClassListDump.java fails with Pattern "CustomLoadee id: [0-9]+ super: [0-9]+ source: .*/custom.jar" not found in classlist

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/537/head:pull/537
$ git checkout pull/537

Update a local copy of the PR:
$ git checkout pull/537
$ git pull https://git.openjdk.java.net/valhalla pull/537/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 537

View PR using the GUI difftool:
$ git pr show -t 537

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/537.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 20, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272793: [lworld] Test CustomClassListDump.java fails with Pattern "CustomLoadee id: [0-9]+ super: [0-9]+ source: .*/custom.jar" not found in classlist

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@fparain
Copy link
Collaborator Author

@fparain fparain commented Aug 20, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2021

Going to push as commit 7553793.

@openjdk openjdk bot closed this Aug 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2021

@fparain Pushed as commit 7553793.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 20, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant