Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273018: [lworld] Property annotation propagation to <init> lacks in primitive records #541

Closed
Closed
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1017,8 +1017,7 @@ void writeMethod(MethodSymbol m) {
}
if (target.hasMethodParameters() && (
options.isSet(PARAMETERS)
|| m.isConstructor() && (m.flags_field & RECORD) != 0
|| m.isPrimitiveObjectFactory() && (m.flags_field & RECORD) != 0)) {
|| ((m.flags_field & RECORD) != 0 && (m.isConstructor() || m.isPrimitiveObjectFactory())))) {
if (!m.isLambdaMethod()) // Per JDK-8138729, do not emit parameters table for lambda bodies.
jespersm marked this conversation as resolved.
Show resolved Hide resolved
acount += writeMethodParametersAttr(m);
}
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -25,6 +25,7 @@
* @test
* @summary test the records can be read by javac properly
* @library /tools/lib
* @bug 8273018
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
* @build toolbox.ToolBox toolbox.JavacTask