8273360: [lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError #546

jespersm · 2021-09-05T13:33:26Z

Update constructor accessor code generation to invoke static factory method.

Progress

Change must not contain extraneous whitespace

Issue

JDK-8273360: [lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError

Reviewers

Mandy Chung (@mlchung - Committer) ⚠️ Review applies to 8bdd857

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/546/head:pull/546
$ git checkout pull/546

Update a local copy of the PR:
$ git checkout pull/546
$ git pull https://git.openjdk.java.net/valhalla pull/546/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 546

View PR using the GUI difftool:
$ git pr show -t 546

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/546.diff

…ass gives InstantiationError

bridgekeeper · 2021-09-05T13:33:30Z

👋 Welcome back jespersm! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-09-05T13:35:17Z

@jespersm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273360: [lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the lworld branch:

2688bf6: 8273018: [lworld] Property annotation propagation to lacks in primitive records
a5cf519: Adjust problem list for initial aarch64 testing
c64b160: Fix header format for build setup
8bed69a: 8273650: [lworld] Interpreter fails with fatal error: DEBUG MESSAGE: klass not initialized
e075eaf: 8270477: [lworld] bytecode testing API does not emit Q type descriptors
0c0c9e1: 8267697: [lworld] [lw3] VM crashes during heap dump if Java heap contains flat arrays
3111124: 8273554: [lworld] Runtime tests should not explicitly set -Xint/-Xcomp
252b04b: 8273323: [lworld] Fix post-parse call devirtualization with inline type receiver

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mlbridge · 2021-09-05T13:38:13Z

Webrevs

jespersm · 2021-09-05T15:13:27Z

/solves 8273360

openjdk · 2021-09-05T15:14:19Z

@jespersm The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

mlchung

@jespersm Thanks for fixing this. A couple comments.

mlchung · 2021-09-10T18:26:13Z

src/java.base/share/classes/jdk/internal/reflect/ClassFileAssembler.java

@@ -49,7 +49,7 @@ public short getLength() {
    public void emitMagicAndVersion() {
        emitInt(0xCAFEBABE);
        emitShort((short) 0);
-        emitShort((short) 49);
+        emitShort((short) 62);


This old bytecode generator does not support stack map and so these reflection classes would need to stay in version 49. JEP 416 changes the core reflection implementation to build on top of method handles and no longer depends on this old bytecode generator.

mlchung · 2021-09-10T18:26:13Z

src/java.base/share/classes/jdk/internal/reflect/MethodAccessorGenerator.java

+        this.isConstructingPrimitive = isConstructor && declaringClass.isPrimitiveClass();
+        if (this.isConstructingPrimitive ) {
+            returnType = declaringClass.asValueType();
+        }


Alternatively, this method can take an additional isStaticFactory parameter. generateConstructor will determine if the declaring class is a primitive class and then call the static factory with the return type argument rather than Void.TYPE.

mlchung · 2021-09-10T18:26:13Z

test/jdk/valhalla/valuetypes/StaticFactoryTest.java

+        for (int i = 0; i < 20; ++i) {
+            Object o = ctor.newInstance();
+            assertTrue(o.getClass() == PRIMITIVE_TYPE.asPrimaryType());
+        }


I suggest to replace this change with @run testng/othervm -Dsun.reflect.noInflation=true StaticFactoryTest so that other test cases will also verify when it's run with the generated bytecode.

mlchung

Looks good. You can integrate once you update the StaticFactoryTest.java.

test/jdk/valhalla/valuetypes/StaticFactoryTest.java

Run both variations Co-authored-by: Mandy Chung <mandy.chung@oracle.com>

jespersm · 2021-09-23T21:17:53Z

Thanks for reviewing, @mlchung !

/integrate

openjdk · 2021-09-23T21:19:43Z

@jespersm
Your change (at version 2afc752) is now ready to be sponsored by a Committer.

mlchung · 2021-09-23T21:43:32Z

/sponsor

openjdk · 2021-09-23T21:45:15Z

Going to push as commit 1303571.
Since your change was applied there have been 8 commits pushed to the lworld branch:

2688bf6: 8273018: [lworld] Property annotation propagation to lacks in primitive records
a5cf519: Adjust problem list for initial aarch64 testing
c64b160: Fix header format for build setup
8bed69a: 8273650: [lworld] Interpreter fails with fatal error: DEBUG MESSAGE: klass not initialized
e075eaf: 8270477: [lworld] bytecode testing API does not emit Q type descriptors
0c0c9e1: 8267697: [lworld] [lw3] VM crashes during heap dump if Java heap contains flat arrays
3111124: 8273554: [lworld] Runtime tests should not explicitly set -Xint/-Xcomp
252b04b: 8273323: [lworld] Fix post-parse call devirtualization with inline type receiver

Your commit was automatically rebased without conflicts.

openjdk · 2021-09-23T21:45:30Z

@mlchung @jespersm Pushed as commit 1303571.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[lworld] Invoking a reflection-generated constructor for primitive cl…

8097982

…ass gives InstantiationError

openjdk bot added ready rfr labels Sep 5, 2021

openjdk bot changed the title ~~[lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError~~ 8273360: [lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError Sep 5, 2021

mlchung reviewed Sep 10, 2021

View changes

Fix review issues

8bdd857

mlchung approved these changes Sep 23, 2021

View changes

test/jdk/valhalla/valuetypes/StaticFactoryTest.java Show resolved Hide resolved

Update test/jdk/valhalla/valuetypes/StaticFactoryTest.java

2afc752

Run both variations Co-authored-by: Mandy Chung <mandy.chung@oracle.com>

openjdk bot added the sponsor label Sep 23, 2021

openjdk bot closed this Sep 23, 2021

openjdk bot added integrated and removed ready rfr sponsor labels Sep 23, 2021

openjdk / valhalla Public

8273360: [lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError #546

8273360: [lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError #546

jespersm commented Sep 5, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Sep 5, 2021

openjdk bot commented Sep 5, 2021 •

edited

mlbridge bot commented Sep 5, 2021 •

edited

jespersm commented Sep 5, 2021

openjdk bot commented Sep 5, 2021

mlchung left a comment •

edited

mlchung Sep 10, 2021

mlchung Sep 10, 2021

mlchung Sep 10, 2021

mlchung left a comment

jespersm commented Sep 23, 2021

openjdk bot commented Sep 23, 2021

mlchung commented Sep 23, 2021

openjdk bot commented Sep 23, 2021

openjdk bot commented Sep 23, 2021

openjdk / valhalla Public

8273360: [lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError #546

8273360: [lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError #546

Conversation

jespersm commented Sep 5, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 5, 2021

openjdk bot commented Sep 5, 2021 • edited

mlbridge bot commented Sep 5, 2021 • edited

Webrevs

jespersm commented Sep 5, 2021

openjdk bot commented Sep 5, 2021

mlchung left a comment • edited

mlchung Sep 10, 2021

Choose a reason for hiding this comment

mlchung Sep 10, 2021

Choose a reason for hiding this comment

mlchung Sep 10, 2021

Choose a reason for hiding this comment

mlchung left a comment

jespersm commented Sep 23, 2021

openjdk bot commented Sep 23, 2021

mlchung commented Sep 23, 2021

openjdk bot commented Sep 23, 2021

openjdk bot commented Sep 23, 2021

jespersm commented Sep 5, 2021 •

edited by openjdk[bot] bot

openjdk bot commented Sep 5, 2021 •

edited

mlbridge bot commented Sep 5, 2021 •

edited

mlchung left a comment •

edited