Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273554: [lworld] Runtime tests should not explicitly set -Xint/-Xcomp #550

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 9, 2021

Many of the runtime tests still specify multiple runs with -Xint/-Xcomp. Setting these flags explicitly reduces coverage because flag combinations set by the CI test jobs are overridden. We should simply not set them in the tests.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8273554: [lworld] Runtime tests should not explicitly set -Xint/-Xcomp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/550/head:pull/550
$ git checkout pull/550

Update a local copy of the PR:
$ git checkout pull/550
$ git pull https://git.openjdk.java.net/valhalla pull/550/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 550

View PR using the GUI difftool:
$ git pr show -t 550

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/550.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273554: [lworld] Runtime tests should not explicitly set -Xint/-Xcomp

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 252b04b: 8273323: [lworld] Fix post-parse call devirtualization with inline type receiver

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Sep 9, 2021

Webrevs

fparain
fparain approved these changes Sep 9, 2021
Copy link
Collaborator

@fparain fparain left a comment

Thank you for fixing those tests.

Fred

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Sep 10, 2021

Thanks, Frederic. I found JDK-8273594 while testing and will fix that before integrating this change.

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Sep 13, 2021

I found more issues with CircularityTest that I need to fix with JDK-8273594. I re-added -Xint for now. Will remove it once JDK-8273594 is in.

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Sep 13, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2021

Going to push as commit 3111124.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 252b04b: 8273323: [lworld] Fix post-parse call devirtualization with inline type receiver

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 13, 2021
@openjdk
Copy link

openjdk bot commented Sep 13, 2021

@TobiHartmann Pushed as commit 3111124.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants