Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273594: [lworld] JITs need to properly handle static inline type field with unloaded type #551

Closed
wants to merge 9 commits into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 10, 2021

Both C1 and C2 do not properly handle loads from static inline type fields with an unloaded type. For C1, the fix is to simply remove two asserts that are too strong. For C2, we need to trap during typeflow analysis.

I've added a corresponding test to TestUnloadedInlineTypeField.java and noticed that the new IR Test Framework often triggers class loading while the test was carefully designed to avoid that. As a workaround, I slightly modified the framework and run the test with -DIgnoreCompilerControls=true. I filed JDK-8273591 to fix this upstream.

I also fixed a -XX:-XX:+PatchALot typo in the test that went unnoticed because -XX:+IgnoreUnrecognizedVMOptions is set.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8273594: [lworld] JITs need to properly handle static inline type field with unloaded type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/551/head:pull/551
$ git checkout pull/551

Update a local copy of the PR:
$ git checkout pull/551
$ git pull https://git.openjdk.java.net/valhalla pull/551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 551

View PR using the GUI difftool:
$ git pr show -t 551

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/551.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 10, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273594: [lworld] JITs need to properly handle static inline type field with unloaded type

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 10, 2021

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Sep 13, 2021

I found more issues with uninitialized classes and fixed them. The new tests currently trigger JDK-8273650, so I'll wait with integration until that is fixed.

Copy link
Collaborator

@fparain fparain left a comment

C1 changes look good to me.

Fred

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Oct 15, 2021

Thanks, Fred!

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Oct 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

Going to push as commit 902a157.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • cff488b: 8275276: [lworld] C2 compilation fails with assert "adr_type for memory phis only"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

@TobiHartmann Pushed as commit 902a157.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants