8273650: [lworld] Interpreter fails with fatal error: DEBUG MESSAGE: klass not initialized #553
Conversation
|
|
|
@fparain This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Webrevs
|
Test looks good, just noticed some typos. I'll verify that it passes with the JIT before integrating JDK-8273594.
| * @test | ||
| * @summary Test several scenarios of class initialization failures | ||
| * @library /test/lib | ||
| * @run main/othervm runtime.valhalla.inlinetypes.ClassInitializationFailuresTest |
There was a problem hiding this comment.
Just noticed that the /othervm part can be removed because no flags are set. Also, the test should use 4-whitespace indentation.
| } | ||
| } | ||
|
|
||
| // Even if a primitive class fails to initialize property, some instances |
There was a problem hiding this comment.
"property" -> "properly"
| // First attempt to instantiate TestClass1 must fail with an ExceptionInInitializerError | ||
| // because an exception has been thrown during the initialization process | ||
| // Second attempt to instantiate TestClass1 must fail with a NoClassDefFoundError | ||
| // because TestClass1 must already be in a faile initialization state (so no new |
There was a problem hiding this comment.
"faile" -> "failed"
|
Thank you for the reviews. Fred |
|
/integrate |
|
Going to push as commit 8bed69a.
Your commit was automatically rebased without conflicts. |
Please review those changes fixing handling of class initialization failures and adding unit tests to cover several failure scenarios and some corner cases (handling of instances from a failed initialization class).
Thank you,
Fred
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/553/head:pull/553$ git checkout pull/553Update a local copy of the PR:
$ git checkout pull/553$ git pull https://git.openjdk.java.net/valhalla pull/553/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 553View PR using the GUI difftool:
$ git pr show -t 553Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/553.diff
The text was updated successfully, but these errors were encountered: