Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245809: [lworld] Remove the last traces of arrayStorageProperties #56

Closed
wants to merge 1 commit into from

Conversation

@MrSimms
Copy link
Member

@MrSimms MrSimms commented May 26, 2020

Removed arrayStorageProperties


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8245809: [lworld] Remove the last traces of arrayStorageProperties

Reviewers

  • Frederic Parain (fparain - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/56/head:pull/56
$ git checkout pull/56

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 26, 2020

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2020

@MrSimms This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245809: [lworld] Remove the last traces of arrayStorageProperties

Reviewed-by: fparain
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the lworld branch:

  • 9a83d9b: 8245584: [lworld] LW3 core reflection update

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 9a83d9b61241f5517d46e7d4a078b1245692e39c.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 26, 2020

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Changes look good to me.

Fred

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented May 27, 2020

/integrate

@openjdk openjdk bot closed this May 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2020

@MrSimms The following commits have been pushed to lworld since your change was applied:

  • 9a83d9b: 8245584: [lworld] LW3 core reflection update

Your commit was automatically rebased without conflicts.

Pushed as commit 8422fb4.

@MrSimms MrSimms deleted the 8245809 branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants