Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245646: [lworld] LW3 Reduce impact of IdentityObject on metaspace #57

Closed
wants to merge 1 commit into from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented May 26, 2020

Please review these changes for JDK-8245646.

This is not a new feature, just an optimization to reduce the number klass arrays containing only IdentityObject begin allocated in metaspaces.

Thank you,

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8245646: [lworld] LW3 Reduce impact of IdentityObject on metaspace

Reviewers

  • David Simms (dsimms - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/57/head:pull/57
$ git checkout pull/57

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 26, 2020

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2020

@fparain This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245646: [lworld] LW3 Reduce impact of IdentityObject on metaspace

Reviewed-by: dsimms
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the lworld branch:

  • ed7a00c: 8245646: [lworld] LW3 Reduce impact of IdentityObject on metaspace
  • 27e8b6e: 8245953: [lworld] Remove array storage property bits clearing from JIT code
  • 8422fb4: 8245809: [lworld] Remove the last traces of arrayStorageProperties
  • 9a83d9b: 8245584: [lworld] LW3 core reflection update

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate ed7a00c6f70a264a1cd3445f5496b53543f4a8bf.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 26, 2020

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Looks good.

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 27, 2020

/integrate

@openjdk openjdk bot closed this May 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2020

@fparain The following commits have been pushed to lworld since your change was applied:

  • 27e8b6e: 8245953: [lworld] Remove array storage property bits clearing from JIT code
  • 8422fb4: 8245809: [lworld] Remove the last traces of arrayStorageProperties
  • 9a83d9b: 8245584: [lworld] LW3 core reflection update

Your commit was automatically rebased without conflicts.

Pushed as commit ed7a00c.

@fparain fparain deleted the identityobject_metadata branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants