Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275825: [lworld] Unnecessary buffering because trivial accessor methods are not C2 compiled #571

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Oct 26, 2021

Trivial accessor (getter/setter) methods are not C2 compiled but remain at C1 level. This is problematic for methods operating on inline type fields because C1 will not perform scalarization in arguments and returns, leading to frequent buffering. The fix is to not treat these methods as trivial.

The fix also includes some refactoring and a fix to AdapterFingerPrint::as_basic_args_string where we hit a ShouldNotReachHere when printing basic types of scalarized inline type argument fields because they are not widened.

Thanks to @kuksenko for reporting!

Best regards,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8275825: [lworld] Unnecessary buffering because trivial accessor methods are not C2 compiled

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/571/head:pull/571
$ git checkout pull/571

Update a local copy of the PR:
$ git checkout pull/571
$ git pull https://git.openjdk.java.net/valhalla pull/571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 571

View PR using the GUI difftool:
$ git pr show -t 571

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/571.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 26, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275825: [lworld] Unnecessary buffering because trivial accessor methods are not C2 compiled

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 26, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Oct 26, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

Going to push as commit 9c886f3.

@openjdk openjdk bot closed this Oct 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@TobiHartmann Pushed as commit 9c886f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant