Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287330: (valhalla) Better modeling of access flags in core reflection #697

Closed
wants to merge 1 commit into from

Conversation

RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented May 25, 2022

Import, verbatim, the new API for access flags to Valhalla; (Not in mainline until jdk 20).
The API is unmodified from the mainline version. Mainline Review openjdk/jdk/7445

The Valhalla modifiers will be added in the new AccessFlags class in a subsequent PR.
The existing Modifiers class will not include Valhalla specific modifiers.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8287330: (valhalla) Better modeling of access flags in core reflection

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/697/head:pull/697
$ git checkout pull/697

Update a local copy of the PR:
$ git checkout pull/697
$ git pull https://git.openjdk.java.net/valhalla pull/697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 697

View PR using the GUI difftool:
$ git pr show -t 697

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/697.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2022

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 25, 2022

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287330: (valhalla) Better modeling of access flags in core reflection

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented May 25, 2022

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to include this. This will allow us to experiment this AccessFlag API and extend it for value types use.

@RogerRiggs
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented May 25, 2022

Going to push as commit 0f7c1c2.

@openjdk openjdk bot added the integrated label May 25, 2022
@openjdk openjdk bot closed this May 25, 2022
@openjdk
Copy link

openjdk bot commented May 25, 2022

@RogerRiggs Pushed as commit 0f7c1c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.


/**
* The dependence is mandatory in the static phase, during compilation,
* but is optional in the dynamic phase, during execution.
*/
STATIC,
STATIC(AccessFlag.STATIC.mask()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should have been AccessFlag.STATIC_PHASE

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fix later

@RogerRiggs RogerRiggs deleted the 8287330-access-flags branch March 14, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants