New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8287330: (valhalla) Better modeling of access flags in core reflection #697
Conversation
|
@RogerRiggs This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to include this. This will allow us to experiment this AccessFlag API and extend it for value types use.
/integrate |
Going to push as commit 0f7c1c2. |
@RogerRiggs Pushed as commit 0f7c1c2. |
|
||
/** | ||
* The dependence is mandatory in the static phase, during compilation, | ||
* but is optional in the dynamic phase, during execution. | ||
*/ | ||
STATIC, | ||
STATIC(AccessFlag.STATIC.mask()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should have been AccessFlag.STATIC_PHASE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fix later
Import, verbatim, the new API for access flags to Valhalla; (Not in mainline until jdk 20).
The API is unmodified from the mainline version. Mainline Review openjdk/jdk/7445
The Valhalla modifiers will be added in the new AccessFlags class in a subsequent PR.
The existing Modifiers class will not include Valhalla specific modifiers.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/697/head:pull/697
$ git checkout pull/697
Update a local copy of the PR:
$ git checkout pull/697
$ git pull https://git.openjdk.java.net/valhalla pull/697/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 697
View PR using the GUI difftool:
$ git pr show -t 697
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/697.diff