Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8236522: NonTearable marker interface for inline classes #7

Closed
wants to merge 1 commit into from

Conversation

rose00
Copy link
Collaborator

@rose00 rose00 commented Mar 28, 2020

Reviewed on valhalla-dev as https://mail.openjdk.java.net/pipermail/valhalla-dev/2020-March/006879.html

(Note: The design is also under discussion by valhalla-spec-experts.)


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8236522: NonTearable marker interface for inline classes to enforce atomicity

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/7/head:pull/7
$ git checkout pull/7

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2020

👋 Welcome back jrose! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2020

@rose00 This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8236522: NonTearable marker interface for inline classes
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Mar 28, 2020

Webrevs

@rose00
Copy link
Collaborator Author

rose00 commented Mar 30, 2020

Targeted regression testing in test/hotspot/jtreg/runtime/valhalla/valuetypes shows only pre-existing failures.

Adding +UnlockDiagnosticVMOptions to JTREG tests, since new option ForceNonTearable is diagnostic.

Pre-existing bug reported as https://bugs.openjdk.java.net/browse/JDK-8241894

@rose00 rose00 changed the title 8236522: non-tearable inline classes 8236522: NonTearable marker interface for inline classes Mar 31, 2020
@rose00
Copy link
Collaborator Author

rose00 commented Mar 31, 2020

/integrate

@openjdk openjdk bot closed this Mar 31, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 31, 2020
@openjdk
Copy link

openjdk bot commented Mar 31, 2020

@rose00
Pushed as commit cab7a5b.

@mlbridge
Copy link

mlbridge bot commented Mar 31, 2020

Mailing list message from John R Rose on valhalla-dev:

Changeset: cab7a5b
Author: John R Rose <jrose at openjdk.org>
Date: 2020-03-31 06:17:43 +0000
URL: https://git.openjdk.java.net/valhalla/commit/cab7a5b9

8236522: NonTearable marker interface for inline classes

! src/hotspot/share/classfile/classFileParser.cpp
! src/hotspot/share/classfile/classFileParser.hpp
! src/hotspot/share/classfile/fieldLayoutBuilder.cpp
! src/hotspot/share/classfile/fieldLayoutBuilder.hpp
! src/hotspot/share/classfile/vmSymbols.hpp
! src/hotspot/share/oops/arrayKlass.hpp
! src/hotspot/share/oops/instanceKlass.hpp
! src/hotspot/share/oops/valueArrayKlass.cpp
! src/hotspot/share/oops/valueArrayKlass.hpp
! src/hotspot/share/oops/valueKlass.cpp
! src/hotspot/share/oops/valueKlass.hpp
! src/hotspot/share/opto/valuetypenode.cpp
! src/hotspot/share/opto/valuetypenode.hpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/utilities/stringUtils.cpp
! src/hotspot/share/utilities/stringUtils.hpp
+ src/java.base/share/classes/java/lang/NonTearable.java
! test/hotspot/jtreg/runtime/valhalla/valuetypes/FlattenableSemanticTest.java
+ test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTearing.java
! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java
! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeDensity.java
! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypesTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant