Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lworld] Incorrect renaming of ValueFieldMaxFlat size in compiler tests #72

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jun 10, 2020

Renamed to InlineFieldMaxFlatSize.


Progress

  • Change must not contain extraneous whitespace

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/72/head:pull/72
$ git checkout pull/72

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Jun 10, 2020

⚠️ @TobiHartmann a branch with the same name as the source branch for this pull request (lworld) is present in the target repository. If you eventually integrate this pull request then the branch lworld in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the lworld branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f lworld 8e35838223e41ce353199c5ca9a1ed15a4d10c76
$ git push -f origin lworld

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

openjdk bot commented Jun 10, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

[lworld] Incorrect renaming of ValueFieldMaxFlat size in compiler tests
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the lworld branch:

  • fce84c0: [lworld] Incorrect renaming of ValueFieldMaxFlat size in compiler tests

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate fce84c0023bebbd204fbce3b42cde8218bf5576e.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Jun 10, 2020

/integrate

@openjdk openjdk bot closed this Jun 10, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 10, 2020
@openjdk
Copy link

openjdk bot commented Jun 10, 2020

@TobiHartmann
Pushed as commit fce84c0.

@openjdk openjdk bot removed the rfr label Jun 10, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant