Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WhiteBox support to fix failing test #79

wants to merge 1 commit into from


Copy link

@hseigel hseigel commented Jun 12, 2020

Update failing test to use whitebox support for dumpBaseArchive(), as is done in similar tests such as The test now passes when run locally.


  • Change must not contain extraneous whitespace


  • Frederic Parain (fparain - Committer)


$ git fetch pull/79/head:pull/79
$ git checkout pull/79

Copy link

bridgekeeper bot commented Jun 12, 2020

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

Copy link

openjdk bot commented Jun 12, 2020

@hseigel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

add WhiteBox support to fix failing test

Reviewed-by: fparain
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate f187e9dbbafcc6aec516b0cab2a0cb124381c3db.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

Copy link

mlbridge bot commented Jun 12, 2020


Copy link

@fparain fparain left a comment

LGTM (not an expert in CDS, but changes look consistent with other tests using dumpBaseArchive().


Copy link

fparain commented Jun 12, 2020

Note: the fix might be impacted by JDK-8245060.

Copy link
Member Author

hseigel commented Jun 12, 2020


@openjdk openjdk bot closed this Jun 12, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 12, 2020
Copy link

openjdk bot commented Jun 12, 2020

Pushed as commit be9744d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants