Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename klass->is_value() to is_inline_klass(), rename oop->is_value t… #89

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jun 17, 2020

A few more renames: change klass->is_value() to is_inline_klass(), rename oop->is_value to is_inline_type(), and a few verify changes including changing inlinetype to *inline_type"


Progress

  • Change must not contain extraneous whitespace

Reviewers

  • Frederic Parain (fparain - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/89/head:pull/89
$ git checkout pull/89

…o oop->is_inline_type, and a few verifier changes
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2020

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2020

@hseigel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

Rename klass->is_value() to is_inline_klass(), rename oop->is_value t…

Reviewed-by: fparain
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate fdfc4b34dfb02569e4dfef1be124aeb1b1c2bb1e.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jun 17, 2020

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Looks good.

Fred

@hseigel
Copy link
Member Author

hseigel commented Jun 17, 2020

/integrate

@openjdk openjdk bot closed this Jun 17, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 17, 2020
@openjdk
Copy link

openjdk bot commented Jun 17, 2020

@hseigel
Pushed as commit cf4c01c.

@openjdk openjdk bot removed the rfr label Jun 17, 2020
@hseigel hseigel deleted the klassRename branch Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants