Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8241918: [lworld] Build failures after JDK-8236522 #9

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Mar 31, 2020

workspace/open/src/hotspot/share/utilities/stringUtils.cpp:276:13: error: 'bool class_list_match_sane()' declared 'static' but never defined [-Werror=unused-function]
[2020-03-31T06:37:08,459Z] static bool class_list_match_sane();
[2020-03-31T06:37:08,459Z] ^~~~~~~~~~~~~~~~~~~~~
[2020-03-31T06:37:08,822Z] cc1plus: all warnings being treated as errors


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8241918: [lworld] Build failures after JDK-8236522

Reviewers

  • David Simms (dsimms - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/9/head:pull/9
$ git checkout pull/9

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 31, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8241918: [lworld] Build failures after JDK-8236522

Reviewed-by: dsimms
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 31, 2020

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Looks good !

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Mar 31, 2020

/integrate

@openjdk openjdk bot closed this Mar 31, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 31, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2020

@TobiHartmann
Pushed as commit ece2a2d.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 31, 2020

Mailing list message from Tobias Hartmann on valhalla-dev:

Changeset: ece2a2d
Author: Tobias Hartmann <thartmann at openjdk.org>
Date: 2020-03-31 10:44:57 +0000
URL: https://git.openjdk.java.net/valhalla/commit/ece2a2d3

8241918: [lworld] Build failures after JDK-8236522

Reviewed-by: dsimms

! src/hotspot/share/utilities/stringUtils.cpp

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 31, 2020

Mailing list message from John Rose on valhalla-dev:

Thanks for the bail-out. Sorry about the mess. ? John

On Mar 31, 2020, at 3:45 AM, Tobias Hartmann <thartmann at openjdk.java.net> wrote:

Changeset: ece2a2d
Author: Tobias Hartmann <thartmann at openjdk.org>
Date: 2020-03-31 10:44:57 +0000
URL: https://git.openjdk.java.net/valhalla/commit/ece2a2d3

8241918: [lworld] Build failures after JDK-8236522

Reviewed-by: dsimms

! src/hotspot/share/utilities/stringUtils.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants