Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314923: [lworld] AllocationMergesTests.java fails IR verification #919

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 25, 2023

The test fails due to JDK-8314999 which will be fixed in mainline (see bug comments for details). I'll put a stop-the-gap-solution in Valhalla. Missing Valhalla support for JDK-8287061 (if any), will be implemented by JDK-8315003.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8314923: [lworld] AllocationMergesTests.java fails IR verification (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/919/head:pull/919
$ git checkout pull/919

Update a local copy of the PR:
$ git checkout pull/919
$ git pull https://git.openjdk.org/valhalla.git pull/919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 919

View PR using the GUI difftool:
$ git pr show -t 919

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/919.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314923: [lworld] AllocationMergesTests.java fails IR verification

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the lworld branch:

  • ae8b7db: Merge jdk
  • a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
  • 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
  • e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
  • 02a0473: 8312445: Array types in annotation elements show square brackets twice
  • c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
  • cc2a75e: 8312619: Strange error message when switching over long
  • 1f81e5b: 8312229: Crash involving yield, switch and anonymous classes
  • ... and 60 more: https://git.openjdk.org/valhalla/compare/8bdf624019dbefa7d2fa583f306f72862b3c4629...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a reasonable temporary fix. Looks good!

@mlbridge
Copy link

mlbridge bot commented Aug 25, 2023

Webrevs

@TobiHartmann
Copy link
Member Author

Thanks Christian!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit ffb2830.
Since your change was applied there have been 70 commits pushed to the lworld branch:

  • ae8b7db: Merge jdk
  • a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
  • 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
  • e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
  • 02a0473: 8312445: Array types in annotation elements show square brackets twice
  • c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
  • cc2a75e: 8312619: Strange error message when switching over long
  • 1f81e5b: 8312229: Crash involving yield, switch and anonymous classes
  • ... and 60 more: https://git.openjdk.org/valhalla/compare/8bdf624019dbefa7d2fa583f306f72862b3c4629...lworld

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@TobiHartmann Pushed as commit ffb2830.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants