[lworld] small reflection implementation clean up

[mlchung]

Post-merge clean up on reflection implementation.

---

Progress

• Change must not contain extraneous whitespace

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/93/head:pull/93
$ git checkout pull/93

[bridgekeeper]

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

[openjdk]

@mlchung This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

[lworld] small reflection implementation clean up

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 118 commits pushed to the lworld branch:

• 45e20dc: LW3 version string
• 609aaed: Merge jdk
• cf4c01c: Rename klass->is_value() to is_inline_klass(), rename oop->is_value t…
• fdfc4b3: Merge jdk
• dc585c2: 8247746: [lworld] TestNullableArray::test78 fails with ZGC due to incorrect result
• aeeaffa: 8247593: Shenandoah: should not block pacing reporters
• 8072069: 8247686: [lworld] C2 compilation fails with assert(!is_default(*igvn)) failed: default value type allocation
• 6d2959b: Merge
• 3237e82: 8247526: [TESTBUG] runtime/cds/appcds/dynamicArchive tests failing with Graal
• a27ee6b: 8236539: Relative link tags in record javadoc don't resolve
• ... and 108 more: https://git.openjdk.java.net/valhalla/compare/eab0f506aa460a1476be35308254ddd40149bb4d...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 45e20dcccc1d454d80d06a8ad1523edd6d8f168c.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlchung]

/integrate

[openjdk]

@mlchung The following commits have been pushed to lworld since your change was applied:

• 45e20dc: LW3 version string
• 609aaed: Merge jdk
• cf4c01c: Rename klass->is_value() to is_inline_klass(), rename oop->is_value t…
• fdfc4b3: Merge jdk
• dc585c2: 8247746: [lworld] TestNullableArray::test78 fails with ZGC due to incorrect result
• aeeaffa: 8247593: Shenandoah: should not block pacing reporters
• 8072069: 8247686: [lworld] C2 compilation fails with assert(!is_default(*igvn)) failed: default value type allocation
• 6d2959b: Merge
• 3237e82: 8247526: [TESTBUG] runtime/cds/appcds/dynamicArchive tests failing with Graal
• a27ee6b: 8236539: Relative link tags in record javadoc don't resolve
• 3e5abda: 8152313: [javadoc] convert tool tests to doclet tests
• dee90e4: 8246098: API for Class::permittedSubclasses should clarify if returned elements are ordered or not
• e7f8e1f: 8211977: move testlibrary tests into one place
• 5073b8c: 8247528: runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java failing with Graal
• e5d3316: 8247660: 12 Uninitialised variable in 1 files
• 66c1d44: rename verifier related value-types, rename JVM_SIGNATURE_VALUETYPE, …
• 55bfd32: 8244561: [lworld] Javac should not allow instantiation of V.ref or V.val
• bf300e8: 8247421: ReturnBlobToWrongHeapTest.java failed allocating blob
• bb06ed4: 8247664: [lworld] Bogus error message: incompatible types while using separate compilation
• 02cec34: 8236647: java/lang/invoke/CallSiteTest.java failed with InvocationTargetException in Graal mode
• f968f32: 8246077: Cloneable test in HmacCore seems questionable
• c55b06a: 8247382: doclint errors (missing comments) in jdk.compiler and jdk.javadoc
• 898c638: 8247530: JfrCheckpointManager failed "assert(!SafepointSynchronize::is_at_safepoint()) failed: invariant"
• 6cdf06f: 8246196: javax/management/MBeanServer/OldMBeanServerTest fails with AssertionError
• 6c3c3da: 8247521: (test) jdk/test/lib/hexdump/HexPrinterTest.java fails on windows
• 246ac15: 8247590: [lworld] JVM_ACC_FIELD_INLINED clashes with ENUM
• b71dac2: 8247575: serviceability/dcmd/gc/HeapDumpCompressedTest unlocks experimental options for Shenandoah and Z
• ad38a9f: 8247567: [lworld] java.lang.AssertionError: Invalid pool entry
• 446e392: 8247578: [lworld] New inlined JVM internal field access constant in java.base
• fd7123b: 8247463: java/nio/channels/etc/OpenAndConnect.java fails due to IPv6 not available
• ca85c5a: 8247522: assert(is_aligned(class_space_rs.base(), class_space_alignment)) failed: Sanity
• e3b04bc: 8247560: Shenandoah: heap iteration holds root locks all the time
• bc73f12: 8247474: Shenandoah: Windows build warning after JDK-8247310
• faaf52c: 8247388: Minimal build broken after JDK-8240245 (undefined reference to `MetaspaceShared::_use_optimized_module_handling')
• 2536cbf: 8245679: KeyStore cannot probe PKCS12 keystore if BouncyCastle is the top security provider
• 241f401: 8247350: [aarch64] assert(false) failed: wrong size of mach node
• e68f81a: 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java
• 4d78c63: 8247357: Flattenable field concept needs some cleanup
• be9744d: add WhiteBox support to fix failing test
• 7b988b3: 8240654: ZGC can cause severe UI application repaint issues
• eeb3c5e: 8247492: ProblemList tools/jlink/plugins/CompressorPluginTest.java
• 4bc69f4: 8247418: Only validate the certificates trust if using the default key user name
• f187e9d: 8246603: [lworld] C2 does not scalarize inline types wrapped into non-escaping box objects
• 19c5bfe: 8247334: Trees.getScope crashes for annotated local records
• 56d333c: Added tag jdk-15+27 for changeset 93813843680b
• 0b8f18b: 8246613: Choose the default SecureRandom algo based on registration ordering
• edefd3c: 8247422: --runtime-image on Mac should work for runtime root
• 2f5d4c6: 8247374: Remove default constructors from javax.net.sslK
• b81f2f1: 8245620: Improve Annotation.annotationType() documentation
• 6341f8c: 8244965: Incorrect error message in vmTestbase/nsk/jdi/VirtualMachine/suspend/suspend001/TestDescription.java
• c0475c8: 8247247: JFR tests fail due to JDK-8235521 missing doPrivileged block
• 30ff2ad: 8246382: assert in MetaspaceShared::map_archives
• 212ab17: 8242923: Trigger interface MethodHandle resolve in test without Nashorn
• 319b4e7: 8246803: Update link to license in Docs.gmk
• a5b5712: 8235496: Start of release updates for JDK 16
• 15999a9: Merge
• 6dec50a: 8247247: JFR tests fail due to JDK-8235521 missing doPrivileged block
• 65455ff: 8207936: TestZipFile.java can fail with an OOM error
• bb86779: 8246031: SSLSocket.getSession() doesn't close connection for timeout/ interrupts
• 4862a00: 8247367: Shenandoah: pacer should wait on lock instead of exponential backoff
• 9ac1ab3: 8247358: Shenandoah: reconsider free budget slice for marking
• 7da56df: Added tag jdk-16+0 for changeset 93813843680b
• 3839c86: 8247200: assert((unsigned)fpargs < 32)
• a512099: 8247675: Update DateFormatterTest Copyright
• 9e4b9e9: 8201575: Allow numbers in VERSION_PRE according to JEP 223
• 77bdc30: 8247470: Fix CHeap GrowableArray NMT accounting
• 0a108f9: 8247605: Avoid array allocation when concatenating with empty string
• e33ebc7: Merge
• c1cd389: 8247524: Remove unnecessary volatile qualifiers from member functions
• 0be5b7d: 8247289: Obsolete unused UseBsdPosixThreadCPUClocks
• 23e2f27: 8246623: Remove minimum 4 digit requirement from Year.parse()
• 38f9a93: 8245307: Update ExchangeImpl to use thread safe DateTimeFormatter
• ab57f7d: 8193686: Allow --with-jtreg to accept a zip compressed jtreg image
• 08df6a1: 8246203: Segmentation fault in verification due to stack overflow with -XX:+VerifyIterativeGVN
• 3341d36: 8247469: getSystemCpuLoad() returns -1 on linux when some offline cpus are present and cpusets.effective_cpus is not available
• 3752a81: 8244926: Add absolute check for int/long to generate Abs nodes
• 76879aa: Merge
• 0f7b18a: 8231560: Remove expired flags in JDK 16
• c82c50b: 8245925: G1 allocates EDEN region after CDS has executed GC
• af83d6a: Merge
• 1faed20: 8247510: typo in IllegalHandshakeMessage
• bac2e7f: 8242328: Update mentions of ThreadMBean to ThreadMXBean
• 8c90f4c: 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java
• 892d998: 8139046: Compiler Control: IGVPrintLevel directive should set PrintIdealGraph
• be278bc: 8246222: Rename javac test T6395981.java to be more informative
• 1a681a4: 8200738: Use --hash-style=gnu for gcc
• 0e4829e: 8245060: remove copying of s.h.WB$WhiteBoxPermission in cds/appcds tests
• c06fe15: 8247492: ProblemList tools/jlink/plugins/CompressorPluginTest.java
• ac46031: 8243290: Improve diagnostic messages for class verification and redefinition failures
• 1b64fb2: 8247334: Trees.getScope crashes for annotated local records
• 24f040d: 8247396: Exclude PCH for files in $(OPT_SPEED_SRC) with clang after JDK-8246751
• 1b75b7d: 8246143: UnreferencedXXX tests fail when run with --illegal-access=deny
• 08304ad: Added tag jdk-16+1 for changeset 4a485c89d5a0
• 494f966: Merge
• 7e05213: 8244282: test/hotspot/jtreg/compiler/intrinsics/Test8237524.java fails with --illegal-access=deny
• 9573099: 8246792: Mac signing tests failed (unsealed contents present in the bundle root)
• 03642a0: 8230744: Several classes throw OutOfMemoryError without message
• 2085fd3: 8247252: TestCombinedCompressedFlags.java failed src/hotspot/share/services/virtualMemoryTracker.cpp:388 Error: ShouldNotReachHere()
• 83d0318: 8239024: Kitchensink24HStress.java failed due to timeout
• 0228a5c: 8245113: JFR Recorder Thread to run in thread state "_thread_in_native"
• b9ce3b4: 8243451: nsk.share.jdi.Debugee.isJFR_active() is incorrect and corresponsing logic seems to be broken
• 6a2e3ca: 8247248: JVM TI Monitor queries might create JNI locals in another thread when using handshakes
• c563c3d: 8241770: Module xxxAnnotation() methods throw NCDFE if module-info.class found as resource in unnamed module
• 96fadef: 8240245: Avoid calling is_shared_class_visible() in SystemDictionary::load_shared_class()
• 6d8c81f: 8245126: Kitchensink fails with: assert(!method->is_old()) failed: Should not be installing old methods
• 2ff9f53: 8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
• bb5e5b3: Added tag jdk-15+27 for changeset 506abc554cae
• 462f806: 8247377: Zero and Minimal VMs are broken after JDK-8198698 ('SystemDictionaryShared' has not been declared)
• 259662f: 8247353: jtreg tests minor issues clean up
• a240133: 8246042: Non-ASCII characters are not handled correctly in the native launcher
• 6098191: 8233244: Add tests for icons configuration in rpm/deb packages
• e3cb4df: 8247235: doclint should permit "self-closing" tags for void elements in HTML5
• 52be894: 8245788: EmptyFolderPackageTest fails on Windows 10
• 7450098: 8247362: HeapDumpComressedTest fails
• 54f7732: 8246721: java/util/Locale/LocaleProvidersRun.java failed on Windows platforms
• b03766f: 8183040: update jdk/test/lib/Platform.java to use NIO file
• 120a0d1: 8247274: (test) HexPrinter cleanup
• 9913602: 8246129: ZIP entries created for DOS epoch include local timezone metadata

Your commit was automatically rebased without conflicts.

Pushed as commit 9cdd26f.

[mlbridge]

Webrevs

• 00: Full (feea858)