New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8248003: [lworld] [lw3] VM crashes when classes with inline type fields are loaded from CDS archive #95
Conversation
|
@fparain This change now passes all automated pre-integration checks, type
Since the source branch of this PR was last updated there have been 3 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
|
Webrevs
|
Mailing list message from Ioi Lam on valhalla-dev: Hi Fred, The changesets look OK to me. It is mixed with both CDS changes and instanceKlass.cpp 2666?? if (has_inline_type_fields()) { systemDictionary.cpp: 1484?? if (ik->has_inline_type_fields()) { [1] Is line 1497 still necessary? test/hotspot/jtreg/runtime/cds/appcds/RewriteBytecodesTest.java Thanks On 6/22/20 5:56 AM, Frederic Parain wrote: |
Mailing list message from Frederic Parain on valhalla-dev: Ioi, Thank you for reviewing these changes. I?m looking at RewriteBytecodesTest.java. Fred
|
The fix has been updated according to Ioi's review, and a new test has been added with class redefinition. Thank you, Fred |
Mailing list message from Ioi Lam on valhalla-dev: Hi Fred, The changes look good to me. For this comment: // Even if the Point class is not loaded from the CDS archive, make sure [1] spelling of WithInlineField -> WithInlinedField // The archived version of WithInlinedField must not be loaded, because Thanks On 6/23/20 10:52 AM, Frederic Parain wrote: |
Ioi, Thank you for the second review. I've updated the comment as you suggested. Fred. |
/integrate |
@fparain The following commits have been pushed to lworld since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 3f8947b. |
Please review this changeset fixing several issues in CDS related to inline type metadata removal and restoration.
Thank you,
Fred
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/valhalla pull/95/head:pull/95
$ git checkout pull/95