Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248167: [lworld] [lw3] JdbInlineTypesTest fails #96

Closed
wants to merge 1 commit into from

Conversation

@fparain
Copy link
Collaborator

@fparain fparain commented Jun 23, 2020

Please review this small fix to stop JdbInlineTypesTest from failing in our testing.

Thank you,

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

Reviewers

  • Harold Seigel (hseigel - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/96/head:pull/96
$ git checkout pull/96

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 23, 2020

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2020

@fparain This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8248167: [lworld] [lw3] JdbInlineTypesTest fails

Reviewed-by: hseigel
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the lworld branch:

  • e5eb253: 8247795: allow factory methods for inline types to return j.l.Obje…

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate e5eb253e426db89440fcec1c4b40ab197eebdf32.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 23, 2020

Webrevs

Copy link
Member

@hseigel hseigel left a comment

Looks good!
Thanks, Harold

@fparain
Copy link
Collaborator Author

@fparain fparain commented Jun 23, 2020

/integrate

@openjdk openjdk bot closed this Jun 23, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2020

@fparain The following commits have been pushed to lworld since your change was applied:

  • e5eb253: 8247795: allow factory methods for inline types to return j.l.Obje…

Your commit was automatically rebased without conflicts.

Pushed as commit d615a33.

@openjdk openjdk bot removed the rfr label Jun 23, 2020
@fparain fparain deleted the fix_JDI branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants