Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247923: [lworld] Empty inline types break calling convention optimization #97

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jun 24, 2020

Empty inline types confuse the calling convention optimization because the injected byte field is not picked up by ciValueKlass::_declared_nonstatic_fields. This patch disables the calling convention optimization for empty inline types and makes sure empty inline types are not allocated by C2. I've filed JDK-8248220 to evaluate further optimization opportunities for empty inline types.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8247923: [lworld] Empty inline types break calling convention optimization

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/97/head:pull/97
$ git checkout pull/97

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8247923: [lworld] Empty inline types break calling convention optimization
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the lworld branch:

  • d615a33: 8248167: [lworld] [lw3] JdbInlineTypesTest fails
  • e5eb253: 8247795: allow factory methods for inline types to return j.l.Obje…

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate d615a338282f4df92b63e36378992095440113e0.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jun 24, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Jun 24, 2020

/integrate

@openjdk openjdk bot closed this Jun 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 24, 2020
@openjdk
Copy link

openjdk bot commented Jun 24, 2020

@TobiHartmann The following commits have been pushed to lworld since your change was applied:

  • d615a33: 8248167: [lworld] [lw3] JdbInlineTypesTest fails
  • e5eb253: 8247795: allow factory methods for inline types to return j.l.Obje…

Your commit was automatically rebased without conflicts.

Pushed as commit 45400b1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant