Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes based on late comments concerning 8247795 fix #99

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jun 24, 2020

Changes based on comments from Mandy after the fix for 8247795 was pushed:

  1. Remove checks for inline unsafe anonymous classes.
  2. Add comment about static factory methods.
  3. Improve test

Tested with tiers 1-2 on windows, linux, and mac, and tiers 3-5 on linux.


Progress

  • Change must not contain extraneous whitespace

Reviewers

  • Mandy Chung (mchung - Committer)
  • lfoltan (no known github.com user name / role)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/99/head:pull/99
$ git checkout pull/99

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 24, 2020

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2020

@hseigel This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

changes based on late comments concerning 8247795 fix

Reviewed-by: mchung
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 806fff417e2adc296428ec4e7b41fff6cdfe1e15.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 24, 2020

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Thanks for making the change, Harold. Looks good.

@hseigel
Copy link
Member Author

@hseigel hseigel commented Jun 24, 2020

/integrate

@openjdk openjdk bot closed this Jun 24, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2020

@hseigel
Pushed as commit 9ba8bbe.

@openjdk openjdk bot removed the rfr label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants