Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Pynamical: Model and Visualize Discrete Nonlinear Dynamical Systems, Chaos, and Fractals #14

Closed
whedon opened this issue Jun 11, 2018 · 33 comments

Comments

@whedon
Copy link

whedon commented Jun 11, 2018

Submitting author: @gboeing (Geoff Boeing)
Repository: https://github.com/gboeing/pynamical
Version: 0.1.2
Editor: @labarba
Reviewers: @drvinceknight

Author instructions

Thanks for submitting your paper to JOSE @gboeing. The JOSE editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@gboeing if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSE and may be suitable for this submission.

Editor instructions

The JOSE submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 11, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Jun 11, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 11, 2018

PDF failed to compile for issue #14 with the following error:

Can't find any papers to compile :-(

@gboeing
Copy link

gboeing commented Jun 11, 2018

Paper is located at https://github.com/gboeing/pynamical/tree/master/paper

@labarba
Copy link
Member

labarba commented Jun 11, 2018

@whedon assign @RobertTalbert as editor

@whedon
Copy link
Author

whedon commented Jun 11, 2018

OK, the editor is @RobertTalbert

@labarba
Copy link
Member

labarba commented Jun 11, 2018

👋 @RobertTalbert — This one's for you, with all the beautiful math!

I'm not sure why our bot can't find the paper. Can you help us with that, @arfon?

@arfon
Copy link
Member

arfon commented Jun 11, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 11, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 11, 2018

PDF failed to compile for issue #14 with the following error:

/app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon.rb:78:in check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError) from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon.rb:66:in initialize'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon/processor.rb:29:in new' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon/processor.rb:29:in set_paper'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/bin/whedon:37:in prepare' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/bin/whedon:99:in <top (required)>'
from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in load' from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in

'

@arfon
Copy link
Member

arfon commented Jun 11, 2018

I'm not sure why our bot can't find the paper. Can you help us with that, @arfon?

Sometimes it takes @whedon a couple of tries...

@openjournals openjournals deleted a comment from whedon Jun 12, 2018
@openjournals openjournals deleted a comment from whedon Jun 12, 2018
@labarba
Copy link
Member

labarba commented Jun 12, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 12, 2018

Attempting PDF compilation. Reticulating splines etc...

@labarba
Copy link
Member

labarba commented Jun 12, 2018

@arfon This PDF build keeps failing. The error message says something about affiliation missing. I checked the paper metadata and the author affiliation is there. What could be going wrong?

@arfon
Copy link
Member

arfon commented Jun 13, 2018

@labarba

Current paper.md:

authors:
  - name: Geoff Boeing
    orcid: 0000-0003-1851-6411
    affiliation: University of California, Berkeley

Expected (as per submission guidelines: http://jose.theoj.org/about#paper_structure):

authors:
  - name: Geoff Boeing
    orcid: 0000-0003-1851-6411
    affiliation: 1
affiliations:
  - name: University of California, Berkeley
    index: 1

@openjournals openjournals deleted a comment from whedon Jun 13, 2018
@labarba
Copy link
Member

labarba commented Jun 13, 2018

@gboeing Have a look at your paper metadata, and fix according to ☝️

@gboeing
Copy link

gboeing commented Jun 13, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 13, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 13, 2018

@gboeing
Copy link

gboeing commented Jun 13, 2018

@labarba done

@labarba
Copy link
Member

labarba commented Jun 13, 2018

Great, it compiled. Can you double check the bibliography? For some reason, the References list appears empty.

@labarba
Copy link
Member

labarba commented Jun 13, 2018

@gboeing Your final passage in the paper addresses the need: please add a heading to mark this "Statement of need." We'd like all papers to include this heading.

@labarba
Copy link
Member

labarba commented Jun 13, 2018

A few short items to add in the paper:

  • has it been used in a classroom setting?
  • how has it been used? how would someone else use it?
  • what's the story behind it? how did the author come to write this?

Thanks!

@labarba
Copy link
Member

labarba commented Jun 13, 2018

@whedon assign @labarba as editor

@whedon whedon assigned labarba and unassigned RobertTalbert Jun 13, 2018
@whedon
Copy link
Author

whedon commented Jun 13, 2018

OK, the editor is @labarba

@gboeing
Copy link

gboeing commented Jun 13, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 13, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 13, 2018

@gboeing
Copy link

gboeing commented Jun 13, 2018

@labarba done

@labarba
Copy link
Member

labarba commented Jun 13, 2018

@whedon assign @drvinceknight as reviewer

@whedon whedon assigned labarba and unassigned labarba Jun 13, 2018
@whedon
Copy link
Author

whedon commented Jun 13, 2018

OK, the reviewer is @drvinceknight

@labarba
Copy link
Member

labarba commented Jun 13, 2018

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Jun 13, 2018

OK, I've started the review over in #15. Feel free to close this issue now!

@labarba labarba closed this as completed Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants