Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: StateMint: A Set of Tools for Determining Symbolic Dynamic System Models Using Linear Graph Methods #44
Comments
whedon
assigned
moorepants
Jan 30, 2019
whedon
added
the
review
label
Jan 30, 2019
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @chrisdembia, it looks like you're currently assigned as the reviewer for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/jose-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@CameronDevine — please bear in mind the comments that @chrisdembia posted on the Pre-Review issue: #38 (comment) @chrisdembia — feel free to re-post those comments here, if you wish. |
This comment has been minimized.
This comment has been minimized.
Yes, @chrisdembia please repost those comments here, so we keep things in one place. |
This comment has been minimized.
This comment has been minimized.
@CameronDevine, this question is not part of the review, just a curiosity. I teach a system dynamics course as well, but I teach the students to use Bond Graphs. I am not familiar with the book you recommend, but the language in your course notes certainly parallels or is the same as the course I teach. The only thing I'm not familiar with is the linear graph representation. Would you mind commenting briefly on any advantages/disadvantages this might have over Bond Graphs? Feel free to email me at moorepants@gmail.com if you don't want to clutter the review. |
This comment has been minimized.
This comment has been minimized.
Please address the following questions in the way you find most appropriate.
a. "The online repository of the software or learning module needs to contain guidelines for potential contributors who may want to: submit changes, make improvements or report issues." I have submitted a PR to your StateMint with additional comments and suggested changes. Web interfaceThe web interface has a beautiful design, and is, overall, easy to follow.
WEB interface tutorial
PythonIt's atypical to put all the code in init.py. Please create more descriptive Python files. Example.ipynb
MathematicaI installed a trial of Mathematica and ran the example without errors. Please state the version of Mathematica with which you tested StateMint. |
This comment has been minimized.
This comment has been minimized.
@CameronDevine, you are welcome to start work on addressing @chrisdembia's review if you have not yet started. @gboeing, we have not heard from you in over a week. Can you update us on the status of your review? |
This comment has been minimized.
This comment has been minimized.
@moorepants I'll be able to complete this by early next week. |
This comment has been minimized.
This comment has been minimized.
Sounds great! |
This comment has been minimized.
This comment has been minimized.
@gboeing Can you give us a status update? |
Feb 14, 2019
This was referenced
This comment has been minimized.
This comment has been minimized.
Overall, the software looks useful and the web interface is very attractively designed. The paper is pretty clear and well-written. Regarding revisions/issues: rather than duplicating them all here, I'll start by saying that @chrisdembia's review covered most of the points I wanted to make. In addition, I have opened two issues in the software's repo CameronDevine/StateMint#9 and CameronDevine/StateMint#10. |
This comment has been minimized.
This comment has been minimized.
Fantastic! @chrisdembia and @gboeing, thank you both for you careful and thoughtful reviews. @CameronDevine The reviewers' comments and requests seem appropriate. The ball is now in your court to address the reviews. Please do so and keep us up-to-date here on your progress or with any questions/comments you have. |
whedon commentedJan 30, 2019
•
edited by gboeing
Submitting author: @CameronDevine (Cameron Devine)
Repository: https://github.com/CameronDevine/StateMint
Version: 2.0.0
Editor: @moorepants
Reviewer: @chrisdembia, @gboeing
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@chrisdembia & @gboeing, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://jose.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @moorepants know.
Review checklist for @chrisdembia
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @gboeing
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?