New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Overlapping: a R package for Estimating Overlapping in Empirical Distributions #1023
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @soodoku, it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
@soodoku, @russellpierce - please carry out your reviews in this issue by updating the checklist above and giving feedback in this issue. The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html Any questions/concerns please let me know. |
@masspator Nice to meet you. I've added several issues to your repo to cover items that I believe are in this checklist. Rather than giving you a lot of extra feedback at this time, I'll pause there and wait to see if that feedback seems useful. :) |
@whedon commands |
Here are some things you can ask me to do:
|
@whedon generate pdf |
|
PDF failed to compile for issue #1023 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in |
@whedon generate pdf |
|
PDF failed to compile for issue #1023 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-8e8528b72684/lib/whedon/author.rb:23:in |
@masspastore - please update your paper YAML header to exactly match the format of this example: https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography Please note that YAML is whitespace sensitive. |
Thanks @arfon I unfortunately added a new reference in the bib file without checking it. |
👋 Hey @masspastore... Letting you know, |
@whedon generate pdf |
|
PDF failed to compile for issue #1023 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-8e8528b72684/lib/whedon/author.rb:23:in |
No, I'm afraid the issue is with the YAML header of your paper. Please update your paper YAML header to match the format of this example: https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography |
@whedon generate pdf |
Thanks @arfon I updated the YAML header as of your suggestion. |
👋 Hey @masspastore... Letting you know, |
@masspastore - please merge this PR too: masspastore/overlapping#9 |
@whedon generate pdf |
|
@soodoku - it looks like there are a few checkboxes un-checked for your review. Is there still work to be done by the author or are you happy to accept here? |
@arfon: need to check a couple of things. i plan to get to it over the weekend. i will be in touch soonish. |
@soodoku thanks for giving it a thorough look. I'll admit that I've been through it enough at this point where I don't have as clear as view on the end result as I might have at the start. So, it is entirely possible I'm missing something. :) I.e. don't take my signoff as a need for less rigour. |
hey @arfon: go for it. |
@masspastore - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission. |
Thanks @arfon - Sure, just done; here is the link: https://zenodo.org/record/1920397#.XAZeVeLTU2x. Doi for Zenodo is 10.5281/zenodo.1920397 |
@whedon set 10.5281/zenodo.1920397 as archive |
OK. 10.5281/zenodo.1920397 is the archive. |
@whedon accept |
|
PDF failed to compile for issue #1023 with the following error: % Total % Received % Xferd Average Speed Time Time Time Current 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 |
@whedon accept |
1 similar comment
@whedon accept |
|
Check final proof 👉 openjournals/joss-papers#100 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#100, then you can now move forward with accepting the submission by compiling again with the flag
|
Hi @masspastore - from a quick inspection, lots of the references in this article likely have DOIs. Could you add a doi field to the bibtex file where possible please? For example, this paper has the DOI |
Hi @arfon, I updated the bib file with all avaliable DOIs Thanks |
@whedon accept |
|
Check final proof 👉 openjournals/joss-papers#105 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#105, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
@soodoku, @russellpierce - many thanks for your reviews here ✨ @masspastore - your paper is now accepted into JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @masspastore (MASSIMILIANO PASTORE)
Repository: https://github.com/masspastore/overlapping
Version: v1.5.0
Editor: @arfon
Reviewer: @soodoku, @russellpierce
Archive: 10.5281/zenodo.1920397
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@soodoku & @russellpierce, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @leeper know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @soodoku
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @russellpierce
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: