Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: Pingouin: statistics in Python #1026
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@snastase, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Review checklist for @snastase
Conflict of interest
Code of Conduct
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
I was hoping to release the version 0.2.0 of Pingouin by early next week and ideally I would really love to include the JOSS paper in it. Do you think that it would be possible to do the review by then? If not, no worries, I'll just include it in a future release.
Thank you and have a great day!
I’m not a very experienced developer (also my first JOSS review), so take this as the perspective of an intermediate-skill-level user. Overall, I think this is a great contribution. Documentation and examples are stellar. I worked through the checklist and point out some minor issues below (most of which I suspect are installation issues that may be peculiar to my environment).
General checklist: general checks are all good (version has progressed to 0.1.10).
Functional checklist: Installation with pip (on Mac) was smooth, although it might be worth including a note for folks like me who still have a python 2.7 installation floating around; e.g.,
I followed the “10 Minutes to Pingouin” walkthrough in IPython on both Mac and Linux machines, and most of it ran smoothly. I ran into the following handful of errors.
I also walked through all of the tutorial notebooks on Binder. This is an excellent approach to interactive examples. I ran into the following issues:
Documentation checklist: Regarding the statement of need, it might be helpful to include in the introductory documentation how this relates to adjacent packages such as
Paper checklist: Everything in order. You might do a final pass over the references to make sure formatting is correct; e.g., most of the journal names in your list are abbreviated, but the Berens reference is not—should be “J. Stat. Softw.”; also capitalize the proceedings name for the McKinney reference.
Random highly-specific feature request: In the
Again, sorry for the delay! Let me know if I can be of help.
Thank you so much for your review and your positive feedback, I really appreciate it!
Please find below the answers to the main points that you mentioned in your review:
Thank you again, Samuel, for your review! Please let me know if there is anything else that I can do.
@raphaelvallat, I think you're all set for now.
@snastase, can you look over the reviewer checklist in the first post in this issue and check off what's all sorted, and see what still needs to be addressed? Apart from that, please look over @raphaelvallat's response and revisions and let us know what you think of the current state of the submission.
Okay, I think the author has adequately addressed my comments! New v0.2.0 fixes my import problems for
Here's what you must now do:
Any issues? notify your editorial technical team...
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: