New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: scarplet: A Python package for topographic template matching and diffusion dating #1066

Closed
whedon opened this Issue Nov 5, 2018 · 49 comments

Comments

Projects
None yet
6 participants
@whedon
Collaborator

whedon commented Nov 5, 2018

Submitting author: @rmsare (Robert Sare)
Repository: https://github.com/rmsare/scarplet
Version: 0.1.0
Editor: @kthyng
Reviewer: @fclubb, @mcflugen
Archive: 10.5281/zenodo.1492786

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/2a23987d6f629b4be281de912f66db69"><img src="http://joss.theoj.org/papers/2a23987d6f629b4be281de912f66db69/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/2a23987d6f629b4be281de912f66db69/status.svg)](http://joss.theoj.org/papers/2a23987d6f629b4be281de912f66db69)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@fclubb & @mcflugen, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @kthyng know.

Please try and complete your review in the next two weeks

Review checklist for @fclubb

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: Does the release version given match the GitHub release (0.1.0)?
  • Authorship: Has the submitting author (@rmsare) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Review checklist for @mcflugen

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: Does the release version given match the GitHub release (0.1.0)?
  • Authorship: Has the submitting author (@rmsare) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 5, 2018

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @fclubb, it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 5, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 5, 2018

@rmsare

This comment has been minimized.

rmsare commented Nov 5, 2018

@kthyng and reviewers - thanks for this! I am tagging co-author @gehilley in case he would like to follow the review.

@mcflugen

This comment has been minimized.

Collaborator

mcflugen commented Nov 6, 2018

@rmsare Nice work 👍I think this is great.

I submitted a couple issues to your repository that address most of the items on our checklist. There are only a couple of other things.

Things to do:

I think that's it for now.

@rmsare

This comment has been minimized.

rmsare commented Nov 7, 2018

@mcflugen Thank you for the thorough review and your work on the conda recipe! I will dig into this and hope to address your comments and implement changes by Monday.

@fclubb

This comment has been minimized.

Collaborator

fclubb commented Nov 8, 2018

Hi @rmsare, thanks for submitting this, the package looks really useful. Here are some notes/comments, which I think are mostly similar those that @mcflugen mentioned.

Installation and functionality

  • Installation worked for me with pip but I couldn't get the code to run due to issues with gdal (rmsare/scarplet#62). I think it would be better to have an environment file so that the gdal install is already taken care of, or do a conda package as was already suggested.
  • Examples: it wasn't immediately clear to me that the example data was included within the GitHub repository, as I had just done a pip install. I have added a comment to the issue that @mcflugen opened.
  • The data for the channel network example is not provided within the GitHub repo so I couldn't test this example. Would need to test this to check all of the functionality of the software.

Software paper

  • I think the software paper needs to include DOIs with the references.

Documentation

  • Readme file could contain a clearer statement of need.
@rmsare

This comment has been minimized.

rmsare commented Nov 10, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 10, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 10, 2018

@rmsare

This comment has been minimized.

rmsare commented Nov 10, 2018

Thanks for your comments @fclubb and @mcflugen.

The example issues have been addressed in some of the PRs above. I've also clarified the statement of need in the README and added DOIs to the paper.

A conda recipe has been submitted that should take care of install problems. I will give it a few days to get into review, and follow up if necessary.

It seems like the best course of action is cutting a new version after I fully address your reviews, and I will release and increment the paper/recipe versions then.

Please let me know if you have any other thoughts or issues.

@rmsare rmsare referenced this issue Nov 13, 2018

Merged

Add scarplet #7026

@kthyng

This comment has been minimized.

kthyng commented Nov 17, 2018

Just a quick check in, @rmsare — looks like you are working on some things, but just want to be sure I'm correct.

@rmsare

This comment has been minimized.

rmsare commented Nov 17, 2018

@kthyng Thanks for the follow up.

I believe I have addressed the points raised so far by both reviewers. Just to clarify, the following changes have been made:

  • Add DOIs to paper
  • Add statement of need to README
  • Refactor example data access
  • Clarify how to run examples and access sample data in both README and docs
  • Change call to a GDAL binary based on @mcflugen's code review
  • Submit package to conda-forge

The remaining issues should be solved once the conda package is accepted. At that point I think @fclubb will be able to install without GDAL problems and verify functionality.

Unfortunately that package review is blocking for now. Please let me know if there's anything I can do in the meantime.

@rmsare

This comment has been minimized.

rmsare commented Nov 20, 2018

@whedon commands

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 20, 2018

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Compile the paper
@whedon generate pdf

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper from a custom git branch
@whedon generate pdf from branch custom-branch-name

@fclubb

This comment has been minimized.

Collaborator

fclubb commented Nov 21, 2018

Hi @rmsare, I have checked the changes that you made and I am happy with submission - I have checked off all the points in my checklist. Nice work!

@mcflugen

This comment has been minimized.

Collaborator

mcflugen commented Nov 21, 2018

@rmsare Yep, looks good to me too! 🎉

@rmsare

This comment has been minimized.

rmsare commented Nov 21, 2018

Thanks to you both for your help and reviews. This submission was a good learning experience for me.

@rmsare

This comment has been minimized.

rmsare commented Nov 21, 2018

@whedon generate pdf

@rmsare

This comment has been minimized.

rmsare commented Nov 21, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 21, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 21, 2018

@rmsare

This comment has been minimized.

rmsare commented Nov 21, 2018

Several multi-author references are being formatted incorrectly. The landlab reference is correct (Hobley, et al., 2017) but others are not.

I'm not sure what the problem is here, as the author lists are all in the same style in paper.bib and use "and" to separate authors. @kthyng (or @arfon), is this a known issue with whedon?

@rmsare

This comment has been minimized.

rmsare commented Nov 21, 2018

The Zenodo archive of the latest release is 10.5281/zenodo.1492786

@arfon

This comment has been minimized.

Member

arfon commented Nov 21, 2018

I'm not sure what the problem is here, as the author lists are all in the same style in paper.bib and use "and" to separate authors. @kthyng (or @arfon), is this a known issue with whedon?

I think you need to separate authors with commas from memory.

@arfon

This comment has been minimized.

Member

arfon commented Nov 21, 2018

Feel free to try tweaking the bibtex and compiling here.

@rmsare

This comment has been minimized.

rmsare commented Nov 21, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 21, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 21, 2018

@rmsare

This comment has been minimized.

rmsare commented Nov 21, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 21, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 21, 2018

@rmsare

This comment has been minimized.

rmsare commented Nov 21, 2018

I'm happy with the formatting as is.

This comes up in other JOSS papers, too, like 10.21105/joss.00979.

(One fix might be to use the natbib package to format citations when compiling the paper. But this looks like it is not compatible with whedon's current use of pandoc.citeproc)

@arfon

This comment has been minimized.

Member

arfon commented Nov 25, 2018

The Zenodo archive of the latest release is 10.5281/zenodo.1492786

@kthyng - are we ready to accept this submission?

@kthyng

This comment has been minimized.

kthyng commented Nov 26, 2018

One more thing:
@rmsare it looks like you have no co-author on your zenodo archive, but you have one on this JOSS submission. Presumably they should match, in which case can you edit the metadata for the zenodo entry?

@rmsare

This comment has been minimized.

rmsare commented Nov 26, 2018

@kthyng, thank you for catching that. I've updated the Zenodo archive to add @gehilley as co-author and note relevant funding sources

@kthyng kthyng added the accepted label Nov 26, 2018

@kthyng

This comment has been minimized.

kthyng commented Nov 26, 2018

Great! We're ready to move forward then @arfon.

@kthyng

This comment has been minimized.

kthyng commented Nov 26, 2018

@whedon set 10.5281/zenodo.1492786 as archive

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 26, 2018

OK. 10.5281/zenodo.1492786 is the archive.

@arfon

This comment has been minimized.

Member

arfon commented Nov 27, 2018

@whedon accept

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 27, 2018

Attempting dry run of processing paper acceptance...
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 27, 2018

Check final proof 👉 openjournals/joss-papers#84

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#84, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
@arfon

This comment has been minimized.

Member

arfon commented Nov 27, 2018

@whedon accept deposit=true

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 27, 2018

Doing it live! Attempting automated processing of paper acceptance...
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 27, 2018

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 openjournals/joss-papers#85
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01066
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

@arfon

This comment has been minimized.

Member

arfon commented Nov 27, 2018

@fclubb, @mcflugen - many thanks for your reviews here and to @kthyng for editing this submission

@rmsare - your paper is now accepted into JOSS ⚡️🚀💥

@arfon arfon closed this Nov 27, 2018

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 27, 2018

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.01066/status.svg)](https://doi.org/10.21105/joss.01066)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01066">
  <img src="http://joss.theoj.org/papers/10.21105/joss.01066/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.01066/status.svg
   :target: https://doi.org/10.21105/joss.01066

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment