New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: OApackage: A Python package for generation and analysis of orthogonal arrays and conference designs #1097
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @djmitche, it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
👋 @djmitche, @tanaken-basis - thanks for agreeing to review this submission. Please see the instructions above and feel free to ask me if you have any questions. Otherwise, I will assume that you will work through the checklist items above, and will bring up any issues with the submission with the author (via very short discussion here or via new issues in the source repo), who will resolve them. |
It's worth noting that the most recent version is 2.5.2 now. That is the same in the repo and the package repository. |
Any updates to the package to improve based on review comments will go to the |
@whedon generate pdf from branch feat/updates_paper_alan |
|
Just a heads up @eendebakpt - compiling from a branch doesn't seem to work very well. You might have to merge to |
All - @tanaken-basis has informed me by email that he needs to be taken off this review because of a personal matter. So I need to find another reviewer - @djmitche, do you have any suggestion for someone else? |
@gsagnol has been added as the second reviewer - thanks! |
👋 @gsagnol - thanks for agreeing to review this submission. Please see the instructions above and feel free to ask me if you have any questions. Otherwise, I will assume that you will work through the checklist items above, and will bring up any issues with the submission with the author (via very short discussion here or via new issues in the source repo), who will resolve them. |
This is my first JOSS review so no, I don't have ideas :/ |
@whedon list reviewers |
Here's the current list of reviewers: https://bit.ly/joss-reviewers |
👋 @gsagnol - how are things going? When will you be able to start on the review (at least the first 2 checkboxes regarding COIs and the JOSS CoC?) |
Hi @danielskatz , I wanted to start with the review this week. I tried to check some of the boxes, but this will not work, although I'm logged in to github. Is google-chrome under linux not supported ? I tried under firefox, but this did not work neither. |
As in the first comment in this thread, can you:
|
That's it... I probably did not accept the invitation, but I guess the invitation link expired: |
👋 @arfon - can you help with this? Or tell me what I can do? |
@gsagnol - I've re-made the invitation here: https://github.com/openjournals/joss-reviews/invitations |
I installed the latest release from github, and |
@gsagnol I don't know about JOSS policy on this matter. I submitted version 2.5.1 to JOSS, but since that moment (also based on reviewers comments) I updated the code and the paper and made a new release. I will continue to push updates based on the review to |
@peendebak : I would like to have a look at your unit tests. I tried to run Do I need a particular version of numpy to execute the testing suite ? Or is there another way to run the unit tests ? |
@peendebak : I posted an issue on the OApackage repository about confusing locations for the documentation (readthedocs.io vs. http://pietereendebak.nl) |
The minimal version of numpy is specified in the Can you also send me the output of the following commands?
|
@eendebakpt - are you happy with everything now? The paper, the software version in the repo, the software that is archived in zenodo? |
@danielskatz We are happy with the paper. Could you update the software version to the latest (2.6.2). We made some small updates to the documentation, but did not change the paper. |
@whedon set 2.6.2 as version |
OK. 2.6.2 is the version. |
@eendebakpt - you need to make an archive of this version of the software, in zenodo or in another repository. See the third bullet in https://joss.readthedocs.io/en/latest/submitting.html#the-review-process (And see https://guides.github.com/activities/citable-code/ for how to do this for Zenodo) Once you have done so, paste the DOI of the archive here. |
@whedon set 2.6.3 as version |
I'm sorry @eendebakpt, I'm afraid I can't do that. That's something only editors are allowed to do. |
@danielskatz To create a zenodo archive I updated the version number of the package, it is now 2.6.3 The DOI of the archive is 10.5281/zenodo.2579025 |
@whedon set 2.6.3 as version |
OK. 2.6.3 is the version. |
@whedon set 10.5281/zenodo.2579025 as archive |
OK. 10.5281/zenodo.2579025 is the archive. |
@whedon accept |
|
Check final proof 👉 openjournals/joss-papers#527 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#527, then you can now move forward with accepting the submission by compiling again with the flag
|
|
@whedon accept deposit=true |
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@danielskatz @gsagnol @djmitche Thanks for reviewing the package. It helped us to improve the package structure. |
🎉🎉🎉 This was the 500th accepted paper in JOSS! 🎉🎉🎉 |
Submitting author: @eendebakpt (Pieter Eendebak)
Repository: https://github.com/eendebakpt/oapackage
Version: 2.6.3
Editor: @danielskatz
Reviewer: @djmitche, @gsagnol
Archive: 10.5281/zenodo.2579025
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@djmitche & @ gsagnol, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @danielskatz know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @djmitche
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @gsagnol
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: