Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: MPIFiles.jl: A Julia Package for Magnetic Particle Imaging Files #1331

Closed
whedon opened this issue Mar 18, 2019 · 60 comments

Comments

Projects
None yet
5 participants
@whedon
Copy link
Collaborator

commented Mar 18, 2019

Submitting author: @tknopp (Tobias Knopp)
Repository: https://github.com/MagneticParticleImaging/MPIFiles.jl
Version: v0.5.3
Editor: @brainstorm
Reviewer: @IgorBaratta
Archive: 10.5281/zenodo.3242352

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/0e06aa80b90b3aaee0cf3a9da52f3760"><img src="http://joss.theoj.org/papers/0e06aa80b90b3aaee0cf3a9da52f3760/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/0e06aa80b90b3aaee0cf3a9da52f3760/status.svg)](http://joss.theoj.org/papers/0e06aa80b90b3aaee0cf3a9da52f3760)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@IgorBaratta, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @brainstorm know.

Please try and complete your review in the next two weeks

Review checklist for @IgorBaratta

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: v0.5.3
  • Authorship: Has the submitting author (@tknopp) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 18, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @IgorBaratta it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 18, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 18, 2019

@labarba

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

👋 @IgorBaratta — Can you give us a quick update on your review?

@tknopp

This comment has been minimized.

Copy link

commented May 16, 2019

@labarba: If there is anything I can do, please let me know. I have a depending paper under review and would of course like to reference the software being used. I could ask in the Julia forum for potential reviewers if @IgorBaratta has no time. Or maybe you have other reviewers in mind. Thanks!

@labarba

This comment has been minimized.

Copy link
Member

commented May 16, 2019

I sent an email to @IgorBaratta, and he replied on May 14, saying he would work on this review and deliver by the end of the week.

@tknopp

This comment has been minimized.

Copy link

commented May 16, 2019

Thanks for the update! Did not want to be pushy, just eager to get my first JOSS review :-)

@IgorBaratta

This comment has been minimized.

Copy link

commented May 18, 2019

Hi @tknopp, @labarba, sorry for not addressing this review sooner!

I found the package quite practical, primarily because of the possibility of reading different file formats in a common interface. I've tested the package functionality with MDF data-sets available in the OpenMPIData repository and the Bruker MPI data-sets used in the tests.

Everything worked out smoothly. Though it took some hours for downloading and testing the big data-sets, as expected.

However, I'd suggest some improvements before recommending acceptance.

Software Paper:

  • The pdf file has lost its formatting. Please check the 3rd paragraph.
  • I would also recommend checking the structure of the 2nd paragraph to improve readability.

Documentation:

  • Example usage - I didn't find any clear example in the documentation. I used the data-sets mentioned above to verify the core functionality of the package, but they are not documented. I'd suggest include at least one example with an actual (small) data-set, maybe in the Getting Started section.

  • Community guidelines – Although there is a clear indication of the issue tracker (to report issues and seek support), I was not able to find any guidelines for contributing to the package.

I hope this review would help improve the package.

@tknopp

This comment has been minimized.

Copy link

commented May 19, 2019

Thank you @IgorBaratta! These are all very good points that definitely need to be addressed. I will work on this and ping you when its ready.

@tknopp

This comment has been minimized.

Copy link

commented May 19, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 19, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 19, 2019

@tknopp

This comment has been minimized.

Copy link

commented May 20, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

@tknopp

This comment has been minimized.

Copy link

commented May 20, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

PDF failed to compile for issue #1331 with the following error:

Error reading bibliography ./paper.bib (line 47, column 4):
unexpected "e"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@tknopp

This comment has been minimized.

Copy link

commented May 20, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

@tknopp

This comment has been minimized.

Copy link

commented May 20, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

PDF failed to compile for issue #1331 with the following error:

Error reading bibliography ./paper.bib (line 33, column 3):
unexpected "p"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@tknopp

This comment has been minimized.

Copy link

commented May 20, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

Attempting PDF compilation. Reticulating splines etc...
@brainstorm

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 9, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 9, 2019


OK DOIs

- 10.1038/nature03808 is OK
- 10.1038/s41467-019-09704-x is OK
- 10.1088/1361-6560/aa6c99 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@brainstorm

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Other than those checklist points, @tknopp, feel free to register a zenodo DOI so we can archive and accept? Thanks everyone!

@IgorBaratta

This comment has been minimized.

Copy link

commented Jun 9, 2019

I see a couple of points unchecked in the checklist: example usage and community guidelines?

My mistake. I guess now they are all checked.

@tknopp

This comment has been minimized.

Copy link

commented Jun 9, 2019

@brainstorm: I am not sure what you mean by "register a zenodo DOI", could you elaborate? Should I register a DOI for one of the references or for the article itself? Would be great to get some help.

@labarba

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Hi @tknopp — The JOSS publication process requires that after all revisions to the software and paper are complete and the reviewers and editor recommend publication, you do the following:

  • make a tagged release of your software, and report the version number here so we can update the metadata
  • make a full deposit of your software in an archive that provides persistence and a global identifier such as a DOI (Zenodo is the most popular, but other archives with similar services exist and are permitted); report the DOI of the software archive here, so we can update the metadata.

You may find this helpful: https://guides.github.com/activities/citable-code/

HTH

@labarba

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

I've read the paper and made some editorial suggestions via this PR
MagneticParticleImaging/MPIFiles.jl#14

@labarba

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Note: after making the Zenodo deposit, be sure to check that it has the correct metadata, and edit as necessary. This includes the title (should match the paper title) and author list (make sure the list is correct and people like me who only fixed some bits of the paper, are not on it). You may also want to add the ORCID of all authors in the Zenodo metadata.

@tknopp

This comment has been minimized.

Copy link

commented Jun 9, 2019

Thanks @labarba, I have merged your changes and initiated a release of the package:

JuliaRegistries/General#1295

Note that this is a two-step procedure in the Julia universe and the github release is done in the second step. I thus need to wait until the upper PR is merged. Then I will create the zenodo DOI.

@tknopp

This comment has been minimized.

Copy link

commented Jun 10, 2019

@labarba: I hope I got this right:

@labarba

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@whedon set v0.5.3 as archive

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

v0.5.3 doesn't look like an archive DOI.

@labarba

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@whedon set 10.5281/zenodo.3242352 as archive

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

OK. 10.5281/zenodo.3242352 is the archive.

@labarba

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@whedon set v0.5.3 as version

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

OK. v0.5.3 is the version.

@labarba labarba added the accepted label Jun 10, 2019

@labarba

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@whedon accept

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

Attempting dry run of processing paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019


OK DOIs

- 10.1038/nature03808 is OK
- 10.1038/s41467-019-09704-x is OK
- 10.1088/1361-6560/aa6c99 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

Check final proof 👉 openjournals/joss-papers#743

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#743, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
@labarba

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@whedon accept deposit=true

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

Doing it live! Attempting automated processing of paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 openjournals/joss-papers#744
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01331
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

@labarba

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Congratulations, @tknopp, your JOSS paper is published! 🚀

Big thanks to our editor: @brainstorm and reviewer: @IgorBaratta 🙏

@labarba labarba closed this Jun 10, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.01331/status.svg)](https://doi.org/10.21105/joss.01331)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01331">
  <img src="http://joss.theoj.org/papers/10.21105/joss.01331/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.01331/status.svg
   :target: https://doi.org/10.21105/joss.01331

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@tknopp

This comment has been minimized.

Copy link

commented Jun 10, 2019

Awesome, thank you very much @labarba, @brainstorm and @IgorBaratta. Will celebrate my first JOSS paper now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.