Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: ACHR.cu: GPU sampling of metabolic networks. #1363

Closed
whedon opened this issue Apr 2, 2019 · 89 comments
Assignees
Labels

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Apr 2, 2019

Submitting author: @marouenbg (Marouen Ben Guebila)
Repository: https://github.com/marouenbg/ACHR.cu
Version: v0.2
Editor: @lpantano
Reviewer: @wmegchel, @prasunanand
Archive: 10.5281/zenodo.3233085

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/536aea75c0eadd41db178b1ca9604067"><img src="http://joss.theoj.org/papers/536aea75c0eadd41db178b1ca9604067/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/536aea75c0eadd41db178b1ca9604067/status.svg)](http://joss.theoj.org/papers/536aea75c0eadd41db178b1ca9604067)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@wmegchel & @prasunanand, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @lpantano know.

Please try and complete your review in the next two weeks

Review checklist for @wmegchel

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: v0.2
  • Authorship: Has the submitting author (@marouenbg) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Review checklist for @prasunanand

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: v0.2
  • Authorship: Has the submitting author (@marouenbg) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Apr 2, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @wmegchel, it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Apr 2, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Apr 2, 2019

@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented Apr 8, 2019

@lpantano @wmegchel @prasunanand
I thought that it can be cumbersome to go through all the dependencies with potentially no access to NVIDIA GPU, below I provide a code ocean capsule which is a container with all the dependencies cached. You can also have reproducible runs of an example.
https://codeocean.com/capsule/2291048/tree/v1
I hope that this helps your assessment.

@lpantano

This comment has been minimized.

Copy link

@lpantano lpantano commented Apr 24, 2019

Thanks for this.

@wmegchel and @prasunanand, it is possible to give an update on the reviewing process?

Thanks so much!

@prasunanand

This comment has been minimized.

Copy link

@prasunanand prasunanand commented Apr 29, 2019

@marouenbg, @lpantano I am unable to download
Dependencies
IBM CPLEX v12.6 (free for academics)

@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented Apr 29, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Apr 29, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Apr 29, 2019

@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented Apr 29, 2019

@prasunanand Thanks for the feedback. I fixed the missing doi in the summary. Which error did you get when you could not download CPLEX?
Otherwise, you can skip the installation part and check an installed version at code ocean https://codeocean.com/capsule/4395814/tree

@prasunanand

This comment has been minimized.

Copy link

@prasunanand prasunanand commented May 19, 2019

Review done!

Nice work @marouenbg

@lpantano

This comment has been minimized.

Copy link

@lpantano lpantano commented May 20, 2019

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 20, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 20, 2019


OK DOIs

- 10.1371/journal.pone.0086587 is OK
- 10.1101/440701 is OK
- 10.1145/1365490.1365500 is OK
- 10.1287/opre.46.1.84 is OK
- 10.1109/hpcsim.2014.6903792 is OK
- 10.1038/s41596-018-0098-2 is OK
- 10.1016/j.cell.2015.05.019 is OK
- 10.1016/j.ymben.2003.09.002 is OK
- 10.1109/99.660313 is OK
- 10.1007/bf02989823 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@lpantano

This comment has been minimized.

Copy link

@lpantano lpantano commented May 20, 2019

Thank @prasunanand and @wmegchel for the nice review. I will proceed with acceptance.

@marouenbg could you create a Zenodo archive for your repository and pass me the DOI link? Make sure the author and title match the paper information. Congrats!

@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented May 21, 2019

Awesome! Thanks @prasunanand for the review. @lpantano I need a couple of days to review the text and the we can proceed with the final version. Thank you!

@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented May 27, 2019

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 27, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 27, 2019


OK DOIs

- 10.1371/journal.pone.0086587 is OK
- 10.1101/440701 is OK
- 10.1145/1365490.1365500 is OK
- 10.1287/opre.46.1.84 is OK
- 10.1109/hpcsim.2014.6903792 is OK
- 10.1038/s41596-018-0098-2 is OK
- 10.1016/j.cell.2015.05.019 is OK
- 10.1016/j.ymben.2003.09.002 is OK
- 10.1109/99.660313 is OK
- 10.1007/bf02989823 is OK
- 10.1038/nbt.2488 is OK
- 10.1128/ecosalplus.10.2.1 is OK
- 10.1186/1752-0509-2-79 is OK

MISSING DOIs

- https://doi.org/10.1007/978-3-642-22194-1_4 may be missing for title: A GPU-based parallel algorithm for large scale linear programming problem
- https://doi.org/10.1145/3297663.3310308 may be missing for title: Simultaneous solving of batched linear programs on a GPU
- https://doi.org/10.1016/j.jpdc.2019.01.001 may be missing for title: Two-dimensional batch linear programming on the GPU

INVALID DOIs

- None
@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented May 27, 2019

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 27, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 27, 2019


OK DOIs

- 10.1371/journal.pone.0086587 is OK
- 10.1101/440701 is OK
- 10.1145/1365490.1365500 is OK
- 10.1287/opre.46.1.84 is OK
- 10.1109/hpcsim.2014.6903792 is OK
- 10.1038/s41596-018-0098-2 is OK
- 10.1016/j.cell.2015.05.019 is OK
- 10.1016/j.ymben.2003.09.002 is OK
- 10.1109/99.660313 is OK
- 10.1007/bf02989823 is OK
- 10.1038/nbt.2488 is OK
- 10.1128/ecosalplus.10.2.1 is OK
- 10.1186/1752-0509-2-79 is OK

MISSING DOIs

- https://doi.org/10.1007/978-3-642-22194-1_4 may be missing for title: A GPU-based parallel algorithm for large scale linear programming problem
- https://doi.org/10.1145/3297663.3310308 may be missing for title: Simultaneous solving of batched linear programs on a GPU
- https://doi.org/10.1016/j.jpdc.2019.01.001 may be missing for title: Two-dimensional batch linear programming on the GPU

INVALID DOIs

- None
@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented May 27, 2019

@whedon generate pdf

@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented May 28, 2019

Hi @lpantano ,
here is the zenodo archive https://zenodo.org/record/3233085#.XO02GNNKii4
DOI/10.5281/zenodo.3233085

@lpantano

This comment has been minimized.

Copy link

@lpantano lpantano commented May 28, 2019

@whedon set 10.5281/zenodo.3233085 as archive

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

OK. 10.5281/zenodo.3233085 is the archive.

@lpantano

This comment has been minimized.

Copy link

@lpantano lpantano commented May 28, 2019

Hi @openjournals/joss-eics,

I think this is complete!

@kyleniemeyer

This comment has been minimized.

Copy link

@kyleniemeyer kyleniemeyer commented May 28, 2019

Hi @marouenbg, I just submitted two minor PRs for the paper and references; could you merge those and then we can rebuild the PDF?

@kyleniemeyer

This comment has been minimized.

Copy link

@kyleniemeyer kyleniemeyer commented May 28, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

Attempting PDF compilation. Reticulating splines etc...
@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented May 28, 2019

Done! Thanks @kyleniemeyer for spotting them out.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

@kyleniemeyer

This comment has been minimized.

Copy link

@kyleniemeyer kyleniemeyer commented May 28, 2019

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019


OK DOIs

- 10.1371/journal.pone.0086587 is OK
- 10.1101/440701 is OK
- 10.1145/1365490.1365500 is OK
- 10.1287/opre.46.1.84 is OK
- 10.1109/hpcsim.2014.6903792 is OK
- 10.1038/s41596-018-0098-2 is OK
- 10.1016/j.cell.2015.05.019 is OK
- 10.1016/j.ymben.2003.09.002 is OK
- 10.1109/99.660313 is OK
- 10.1007/bf02989823 is OK
- 10.1038/nbt.2488 is OK
- 10.1128/ecosalplus.10.2.1 is OK
- 10.1186/1752-0509-2-79 is OK
- 10.1007/978-3-642-22194-1_4 is OK
- 10.1145/3297663.3310308 is OK
- 10.1016/j.jpdc.2019.01.001 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@kyleniemeyer

This comment has been minimized.

Copy link

@kyleniemeyer kyleniemeyer commented May 28, 2019

@whedon accept

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

Attempting dry run of processing paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019


OK DOIs

- 10.1371/journal.pone.0086587 is OK
- 10.1101/440701 is OK
- 10.1145/1365490.1365500 is OK
- 10.1287/opre.46.1.84 is OK
- 10.1109/hpcsim.2014.6903792 is OK
- 10.1038/s41596-018-0098-2 is OK
- 10.1016/j.cell.2015.05.019 is OK
- 10.1016/j.ymben.2003.09.002 is OK
- 10.1109/99.660313 is OK
- 10.1007/bf02989823 is OK
- 10.1038/nbt.2488 is OK
- 10.1128/ecosalplus.10.2.1 is OK
- 10.1186/1752-0509-2-79 is OK
- 10.1007/978-3-642-22194-1_4 is OK
- 10.1145/3297663.3310308 is OK
- 10.1016/j.jpdc.2019.01.001 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

Check final proof 👉 openjournals/joss-papers#719

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#719, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
@lpantano

This comment has been minimized.

Copy link

@lpantano lpantano commented May 28, 2019

Do the last changes change the Zenode DOI or/and version?

@kyleniemeyer

This comment has been minimized.

Copy link

@kyleniemeyer kyleniemeyer commented May 28, 2019

@lpantano they were only minor changes to the paper, which we archive, so I wasn't worried about updating the Zenodo record

@kyleniemeyer

This comment has been minimized.

Copy link

@kyleniemeyer kyleniemeyer commented May 28, 2019

@whedon accept deposit=true

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

Doing it live! Attempting automated processing of paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 openjournals/joss-papers#720
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01363
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

@kyleniemeyer

This comment has been minimized.

Copy link

@kyleniemeyer kyleniemeyer commented May 28, 2019

Congrats @marouenbg on your paper's publication in JOSS! Thanks also to @wmegchel and @prasunanand for reviewing, and @lpantano for editing!

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented May 28, 2019

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.01363/status.svg)](https://doi.org/10.21105/joss.01363)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01363">
  <img src="http://joss.theoj.org/papers/10.21105/joss.01363/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.01363/status.svg
   :target: https://doi.org/10.21105/joss.01363

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented Nov 25, 2019

@kyleniemeyer @arfon I just realized I had small typo in the title. First, a dash is missing in gpu accelerated. Second the title line ends with a full stop, which gives me references with two full stops. Is it possible to amend the title? Otherwise it is fine like it is.

@arfon

This comment has been minimized.

Copy link
Member

@arfon arfon commented Nov 25, 2019

@marouenbg - can you make your changes to the paper.md file and I can then update the paper.

@marouenbg

This comment has been minimized.

Copy link

@marouenbg marouenbg commented Nov 27, 2019

@arfon I just corrected the title in paper.md. Thanks!

@arfon

This comment has been minimized.

Copy link
Member

@arfon arfon commented Nov 27, 2019

OK that's now updated. The changes might take a few hours to update as there's caching in place on the JOSS site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.