Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: stingray: A modern Python library for spectral timing #1393
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@Cadair, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Review checklist for @Cadair
Conflict of interest
Code of Conduct
referenced this issue
Apr 18, 2019
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
@Cadair - please carry out your review in this issue by updating the checklist above and giving feedback in this issue. The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html
Any questions/concerns please let me know.
@dhuppenkothen Really glad to stingray hit a major milestone
A couple of notes from the review:
I will have a play around with the code and complete my review as soon as I can (my train is about to arrive and I want to push send on this before it does
I had a response all typed out and then somehow forgot to actually send it. Thank you @Cadair for the comments!
I realized I don't know whether the JOSS paper gets automatically updated from our master branch. Do I need to complete a separate step to make sure everything gets updated?
Great! @dhuppenkothen - at this point could you:
I can then move forward with accepting the submission.
PDF failed to compile for issue #1393 with the following error:
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: